Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): KameletBinding native mode #3670

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Sep 23, 2022

Release Note

chore(test): KameletBinding native mode

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Sep 23, 2022

Test to cover #3671

@oscerd
Copy link
Contributor

oscerd commented Sep 23, 2022

Please don't use internal JIRA issue for upstream PR. It's not relevant.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Sep 23, 2022

yes, I can copy-paste the content of the ENTESB issue and create an upstream one.

@squakez squakez changed the title Native binding chore(test): KameletBinding native mode Sep 23, 2022
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the test is failing with:

=== CONT  TestNativeIntegrations
    native_test.go:125: 
        Timed out after 60.003s.
        Expected
            <string>: ./camel-k-integration-1.11.0-SNAPSHOT-runner
        to match regular expression
            <string>: .*camel-k-integration-\d+\.\d+\.\d+-runner.*

We probably need to account for the snapshot and let any generic tag there.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Sep 27, 2022

It seems the test is failing with:

=== CONT  TestNativeIntegrations
    native_test.go:125: 
        Timed out after 60.003s.
        Expected
            <string>: ./camel-k-integration-1.11.0-SNAPSHOT-runner
        to match regular expression
            <string>: .*camel-k-integration-\d+\.\d+\.\d+-runner.*

We probably need to account for the snapshot and let any generic tag there.

Thank you for spotting that! The generic matcher mated the java command too. I fixed the regex so let's wait for the results 🙏.

@christophd
Copy link
Contributor

@bouskaJ since #3682 has been merged as a potential fix for this test could you please rebase and update this PR. Hopefully the e2e test is successful then 🤞

@christophd
Copy link
Contributor

@bouskaJ that last job run looks promising isn't it?

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Oct 4, 2022

@bouskaJ that last job run looks promising isn't it?

yes, the install / native-it is green 🎉 we are good to go IMO.

@squakez
Copy link
Contributor

squakez commented Oct 4, 2022

Failing checks not related. @bouskaJ please, backport to 1.10 and 1.8 (lts) branches to make sure we don't have any failure over there as well.

@squakez squakez merged commit 995a107 into apache:main Oct 4, 2022
This was referenced Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants