-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Force arguments for the rebuild command #3556
Conversation
9c18699
to
02a6a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few minor change requests.
@tadayosi @squakez Thx for your feedback, actually the remarks that you both raised are about the code that I reused from the |
We can take the opportunity and do the necessary cleaning on the other commands as well. |
Ok, No problem, I will do that next week then thx |
02a6a90
to
03964fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
fixes #3445
Motivation
Allowing to accept no arguments to rebuild all the integrations is a bit risky so a new flag for this purpose must be explicitly provided by the end user.
Modifications:
--all
to the rebuild command to rebuild all integrationsRelease Note