Skip to content

Commit

Permalink
fix: Align the code of commands with --all flag
Browse files Browse the repository at this point in the history
  • Loading branch information
essobedo authored and tadayosi committed Aug 30, 2022
1 parent 1100a8e commit eff8256
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 37 deletions.
10 changes: 3 additions & 7 deletions pkg/cmd/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@ func newCmdDelete(rootCmdOptions *RootCmdOptions) (*cobra.Command, *deleteCmdOpt
if err := options.validate(args); err != nil {
return err
}
if err := options.run(cmd, args); err != nil {
fmt.Fprintln(cmd.ErrOrStderr(), err.Error())
}

return nil
return options.run(cmd, args)
},
}

Expand All @@ -66,10 +62,10 @@ type deleteCmdOptions struct {

func (command *deleteCmdOptions) validate(args []string) error {
if command.DeleteAll && len(args) > 0 {
return errors.New("invalid combination: both all flag and named integrations are set")
return errors.New("invalid combination: --all flag is set and at least one integration name is provided")
}
if !command.DeleteAll && len(args) == 0 {
return errors.New("invalid combination: neither all flag nor named integrations are set")
return errors.New("invalid combination: provide one or several integration names or set --all flag for all integrations")
}

return nil
Expand Down
15 changes: 5 additions & 10 deletions pkg/cmd/kamelet_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,14 @@ func newKameletDeleteCmd(rootCmdOptions *RootCmdOptions) (*cobra.Command, *kamel
}

cmd := cobra.Command{
Use: "delete <name>",
Short: "Delete a Kamelet",
Long: `Delete a Kamelet.`,
Use: "delete [Kamelet1] [Kamelet2] ...",
Short: "Delete Kamelets deployed on Kubernetes",
PreRunE: decode(&options),
RunE: func(cmd *cobra.Command, args []string) error {
if err := options.validate(args); err != nil {
return err
}
if err := options.run(cmd, args); err != nil {
fmt.Fprintln(cmd.ErrOrStderr(), err.Error())
}

return nil
return options.run(cmd, args)
},
}

Expand All @@ -63,10 +58,10 @@ type kameletDeleteCommandOptions struct {

func (command *kameletDeleteCommandOptions) validate(args []string) error {
if command.All && len(args) > 0 {
return errors.New("invalid combination: both all flag and named kamelets are set")
return errors.New("invalid combination: --all flag is set and at least one kamelet name is provided")
}
if !command.All && len(args) == 0 {
return errors.New("invalid combination: neither all flag nor named kamelets are set")
return errors.New("invalid combination: provide one or several kamelet names or set --all flag for all kamelets")
}

return nil
Expand Down
15 changes: 5 additions & 10 deletions pkg/cmd/kit_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,14 @@ func newKitDeleteCmd(rootCmdOptions *RootCmdOptions) (*cobra.Command, *kitDelete
}

cmd := cobra.Command{
Use: "delete <name>",
Short: "Delete an Integration Kit",
Long: `Delete an Integration Kit.`,
Use: "delete [integration kit1] [integration kit2] ...",
Short: "Delete integration kits deployed on Kubernetes",
PreRunE: decode(&options),
RunE: func(cmd *cobra.Command, args []string) error {
if err := options.validate(args); err != nil {
return err
}
if err := options.run(cmd, args); err != nil {
fmt.Fprintln(cmd.ErrOrStderr(), err.Error())
}

return nil
return options.run(cmd, args)
},
}

Expand All @@ -64,10 +59,10 @@ type kitDeleteCommandOptions struct {

func (command *kitDeleteCommandOptions) validate(args []string) error {
if command.All && len(args) > 0 {
return errors.New("invalid combination: both all flag and named Kits are set")
return errors.New("invalid combination: --all flag is set and at least one integration kit name is provided")
}
if !command.All && len(args) == 0 {
return errors.New("invalid combination: neither all flag nor named Kits are set")
return errors.New("invalid combination: provide one or several integration kit names or set --all flag for all integration kits")
}

return nil
Expand Down
12 changes: 4 additions & 8 deletions pkg/cmd/rebuild.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,7 @@ func newCmdRebuild(rootCmdOptions *RootCmdOptions) (*cobra.Command, *rebuildCmdO
if err := options.validate(args); err != nil {
return err
}
if err := options.rebuild(cmd, args); err != nil {
fmt.Fprintln(cmd.ErrOrStderr(), err.Error())
}

return nil
return options.run(cmd, args)
},
}

Expand All @@ -62,16 +58,16 @@ type rebuildCmdOptions struct {

func (o *rebuildCmdOptions) validate(args []string) error {
if o.RebuildAll && len(args) > 0 {
return errors.New("invalid combination: both all flag and named integrations are set")
return errors.New("invalid combination: --all flag is set and at least one integration name is provided")
}
if !o.RebuildAll && len(args) == 0 {
return errors.New("invalid combination: neither all flag nor named integrations are set")
return errors.New("invalid combination: provide one or several integration names or set --all flag for all integrations")
}

return nil
}

func (o *rebuildCmdOptions) rebuild(cmd *cobra.Command, args []string) error {
func (o *rebuildCmdOptions) run(cmd *cobra.Command, args []string) error {
c, err := o.GetCmdClient()
if err != nil {
return err
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/trait_help.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ type traitMetaData struct {

func (command *traitHelpCommandOptions) validate(args []string) error {
if command.IncludeAll && len(args) > 0 {
return errors.New("invalid combination: both all flag and a named trait is set")
return errors.New("invalid combination: --all flag is set and a trait name is provided")
}
if !command.IncludeAll && len(args) == 0 {
return errors.New("invalid combination: neither all flag nor a named trait is set")
return errors.New("invalid combination: provide a trait name or set --all flag for all traits")
}
return nil
}
Expand Down

0 comments on commit eff8256

Please sign in to comment.