[Backport 1.8.x] dev sandbox fixes #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadayosi
reviewed
Jun 29, 2022
(cherry picked from commit 8f3f635)
christophd
force-pushed
the
backport-1.8.x/dev-sandbox-fixes
branch
from
3305441 to
e420062
Compare
|
@tadayosi seems like the validation failures and tests failing is something that has already been happening for a long time before on this 1.8.x branch. I have fixed the validation errors now with this PR. Yet I am not sure how to handle the other test failures since it is hard to understand what tests are failing because of this PR. |
tadayosi
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of dev sandbox related fixes