feat(gc): Use SelfSubjectRulesReview to scan for garbage collectable resources #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadayosi
approved these changes
Jun 2, 2022
tadayosi
reviewed
Jun 2, 2022
|
|
||
| // Retrieve the permissions granted to the operator service account. | ||
| // We assume the operator has only to garbage collect the resources it has created. | ||
| srr := &authorization.SelfSubjectRulesReview{ |
There was a problem hiding this comment.
Just for confirmation, don't we need to also check it with OpenShift version of SSRR if it's on OpenShift? Is it redundant?
https://docs.openshift.com/container-platform/4.10/rest_api/authorization_apis/selfsubjectrulesreview-authorization-openshift-io-v1.html
There was a problem hiding this comment.
Based on the testing I've done, authorization.k8s.io works also in OpenShift. Generally it seems vanilla k8s APIs are supported in OpenShift and somehow translated into their OpenShift counterpart if any.
|
Let me merge this. The test failure in the OpenShift workflow is also present in main branch. |
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GC trait currently scans all the resources based on the set of types returned by the Discovery API. This leads to a significant number of unauthorised requests, that have proved to overload the API server unnecessarily.
This PR improves the GC trait, to rely on SelfSubjectRulesReview requests, to scan for garbage collectable resources, assuming the operator can only garbage collect resources it has previously created.
Rate limiting is also added, so that one SelfSubjectRulesReview request is performed over a minute period at the maximum, allowing to refresh the cached set of collectable types, should the permissions granted to the operator service account changed at runtime.
Release Note