Reworked logging trait dependencies #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added bonus of this is that the container does not required a rebuild if the |
astefanutti
reviewed
Aug 18, 2021
orpiske
force-pushed
the
logging-cleanup-2541
branch
from
074c323 to
a6d68aa
Compare
astefanutti
reviewed
Aug 18, 2021
orpiske
force-pushed
the
logging-cleanup-2541
branch
from
a6d68aa to
2321757
Compare
As part of GH issue apache#2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
astefanutti
approved these changes
Aug 18, 2021
|
So, I think we need to wait before merging this because it depends on Camel K Runtime 1.9. We are currently defaulting to 1.8.0 on the Makefile. |
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of GH issue #2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
Depends on apache/camel-k-runtime#731
Release Note