Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate/Cleanup logging trait dependency #2541

Closed
2 of 3 tasks
orpiske opened this issue Aug 2, 2021 · 0 comments · Fixed by #2580
Closed
2 of 3 tasks

Evaluate/Cleanup logging trait dependency #2541

orpiske opened this issue Aug 2, 2021 · 0 comments · Fixed by #2580
Assignees
@orpiske
Labels
area/observability Logging, monitoring and tracing kind/task General activity
Milestone
1.6.0

Comments

@orpiske
Copy link
Contributor

orpiske commented Aug 2, 2021 •
edited
Loading

This is based on a suggestion from @lburgazzoli for cleaning up the quarkus json logging dependency. Quoting his suggestion:

... wonder if we can add io.quarkus:quarkus-logging-json as transitive dependency o camel-k so this trait would not need to change the dependencies. This would also ensure the dependency to be present inc case you provide your own container image

  • make the quarkus-logging-json dependency as a transitive dependency of Camel to avoid changing dependencies on the trait code
  • also reconsider the default behavior (i.e.: what to do if the flag is not provided). @astefanutti raised the point on the discussion for this PR.
  • as a follow up of the above, we need to document the default behavior, so it is clearer what is the expectation when a flag is not provided.
@orpiske orpiske self-assigned this Aug 2, 2021
@orpiske orpiske added area/observability Logging, monitoring and tracing kind/task General activity labels Aug 2, 2021
@orpiske orpiske added this to the 1.6.0 milestone Aug 2, 2021
@orpiske orpiske mentioned this issue Aug 2, 2021
Merged
orpiske added a commit to orpiske/camel-k-runtime that referenced this issue Aug 18, 2021
@orpiske
Added quarkus-logging-json as a runtime dependency
8693b91 
As part of GH issue apache/camel-k#2541, moved the dependency to the
runtime to ensure it's always present, even with custom base images or other
customizations. This also allow us to manage the dependencies on a
single place instead of spreading them over the codebase.
@orpiske orpiske mentioned this issue Aug 18, 2021
Merged
orpiske added a commit to orpiske/camel-k that referenced this issue Aug 18, 2021
@orpiske
Reworked logging trait dependencies
074c323 
As part of GH issue apache#2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
@orpiske orpiske mentioned this issue Aug 18, 2021
Merged
orpiske added a commit to orpiske/camel-k that referenced this issue Aug 18, 2021
@orpiske
Reworked logging trait dependencies
a6d68aa 
As part of GH issue apache#2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
orpiske added a commit to orpiske/camel-k that referenced this issue Aug 18, 2021
@orpiske
Reworked logging trait dependencies
2321757 
As part of GH issue apache#2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
orpiske added a commit to apache/camel-k-runtime that referenced this issue Aug 18, 2021
@orpiske
Added quarkus-logging-json as a runtime dependency
9bdcc65 
As part of GH issue apache/camel-k#2541, moved the dependency to the
runtime to ensure it's always present, even with custom base images or other
customizations. This also allow us to manage the dependencies on a
single place instead of spreading them over the codebase.
@orpiske orpiske linked a pull request Aug 23, 2021 that will close this issue
Reworked logging trait dependencies #2580
Merged
orpiske added a commit that referenced this issue Aug 31, 2021
@orpiske
Reworked logging trait dependencies
67b71e8 
As part of GH issue #2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
orpiske added a commit that referenced this issue Sep 1, 2021
@orpiske
Reworked logging trait dependencies
e38c6ea 
As part of GH issue #2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orpiske orpiske

Labels
area/observability Logging, monitoring and tracing kind/task General activity
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Reworked logging trait dependencies orpiske/camel-k
1 participant
@orpiske