Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing license #4700

Closed
squakez opened this issue Aug 30, 2023 · 12 comments · Fixed by #4763
Closed

Missing license #4700

squakez opened this issue Aug 30, 2023 · 12 comments · Fixed by #4763
Assignees
@squakez
Labels
kind/bug Something isn't working

Comments

@squakez
Copy link
Contributor

squakez commented Aug 30, 2023 •
edited
Loading

See comment
@squakez squakez added the kind/bug Something isn't working label Aug 30, 2023
@squakez
Copy link
Contributor Author

squakez commented Aug 30, 2023 

./script/check_licenses.sh
file ./e2e/common/misc/files/registry/src/main/java/camelk/DeterministicDecryption.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1/integrationplatformstatus/Configuration.java does not contain license
...
file ./java/target/checkout/java/target/generated-sources/java/org/apache/camel/v1alpha1/KameletStatus.java does not contain license
file ./java/target/apidocs/type-search-index.js does not contain license
file ./java/target/apidocs/search.js does not contain license
file ./java/target/apidocs/script.js does not contain license
file ./java/target/apidocs/package-search-index.js does not contain license
file ./java/target/apidocs/jquery/jquery-ui.min.js does not contain license
file ./java/target/apidocs/jquery/external/jquery/jquery.js does not contain license
file ./java/target/apidocs/jquery/jszip-utils/dist/jszip-utils-ie.js does not contain license
file ./java/target/apidocs/jquery/jszip-utils/dist/jszip-utils.min.js does not contain license
file ./java/target/apidocs/jquery/jszip-utils/dist/jszip-utils.js does not contain license
file ./java/target/apidocs/jquery/jszip-utils/dist/jszip-utils-ie.min.js does not contain license
file ./java/target/apidocs/jquery/jquery-3.6.1.min.js does not contain license
file ./java/target/apidocs/jquery/jszip/dist/jszip.js does not contain license
file ./java/target/apidocs/jquery/jszip/dist/jszip.min.js does not contain license
file ./java/target/apidocs/member-search-index.js does not contain license
file ./java/target/checkout/docs/modules/ROOT/examples/js/ck.js does not contain license
file ./java/target/checkout/java/target/apidocs/type-search-index.js does not contain license
file ./java/target/checkout/java/target/apidocs/search.js does not contain license
file ./java/target/checkout/java/target/apidocs/script.js does not contain license
file ./java/target/checkout/java/target/apidocs/package-search-index.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jquery-ui.min.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/external/jquery/jquery.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jszip-utils/dist/jszip-utils-ie.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jszip-utils/dist/jszip-utils.min.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jszip-utils/dist/jszip-utils.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jszip-utils/dist/jszip-utils-ie.min.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jquery-3.6.1.min.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jszip/dist/jszip.js does not contain license
file ./java/target/checkout/java/target/apidocs/jquery/jszip/dist/jszip.min.js does not contain license
file ./java/target/checkout/java/target/apidocs/member-search-index.js does not contain license
file ./java/target/javadoc-bundle-options/javadoc-options-javadoc-resources.xml does not contain license
file ./java/target/checkout/java/target/javadoc-bundle-options/javadoc-options-javadoc-resources.xml does not contain license
file ./e2e/yaks/common/kamelet-binding-broker/sample-broker.yaml does not contain license
file ./cicd/tekton/kamel-run/0.1/support/camel-k-tekton.yaml does not contain license
file ./cicd/tekton/kamel-run/0.1/tests/run.yaml does not contain license
file ./cicd/tekton/kamel-run/0.1/tests/resources.yaml does not contain license
file ./cicd/tekton/kamel-run/0.1/samples/run-external-build.yaml does not contain license
file ./cicd/tekton/kamel-run/0.1/samples/run-operator-build.yaml does not contain license
file ./cicd/tekton/kamel-run/0.1/kamel-run.yaml does not contain license
file ./resources/traits.yaml does not contain license
file ./java/target/checkout/e2e/yaks/common/kamelet-binding-broker/sample-broker.yaml does not contain license
file ./java/target/checkout/docs/charts/index.yaml does not contain license
file ./java/target/checkout/cicd/tekton/kamel-run/0.1/support/camel-k-tekton.yaml does not contain license
file ./java/target/checkout/cicd/tekton/kamel-run/0.1/tests/run.yaml does not contain license
file ./java/target/checkout/cicd/tekton/kamel-run/0.1/tests/resources.yaml does not contain license
file ./java/target/checkout/cicd/tekton/kamel-run/0.1/samples/run-external-build.yaml does not contain license
file ./java/target/checkout/cicd/tekton/kamel-run/0.1/samples/run-operator-build.yaml does not contain license
file ./java/target/checkout/cicd/tekton/kamel-run/0.1/kamel-run.yaml does not contain license
file ./java/target/checkout/resources/traits.yaml does not contain license
file ./java/target/checkout/docs/source-watch.yml does not contain license
file ./java/target/checkout/docs/source-map.yml does not contain license
file ./java/target/checkout/docs/antora.yml does not contain license
file ./script/release-branch.sh does not contain license
file ./java/target/checkout/script/release-branch.sh does not contain license
file ./java/target/checkout/docs/local-build.sh does not contain license

@squakez squakez changed the title [Bug]: Missing license Missing license Sep 6, 2023
@squakez
Copy link
Contributor Author

squakez commented Sep 20, 2023 •
edited
Loading

@andreaTP could you please advice how to configure the plugin to generate some license header for all java classes?

...
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/Source.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/types/schema/ExternalDocs.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/types/schema/Properties.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/types/Schema.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/Types.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/Ref.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/Properties.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/kameletbindingspec/steps/DataTypes.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/KameletBindingStatus.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/KameletBindingSpec.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/KameletBinding.java does not contain license
file ./java/target/generated-sources/java/org/apache/camel/v1alpha1/KameletStatus.java does not contain license

squakez added a commit to squakez/camel-k that referenced this issue Sep 20, 2023
@squakez
fix(ci): license check
f33ceee 
Ref apache#4700
@squakez squakez mentioned this issue Sep 20, 2023
Merged
@squakez squakez self-assigned this Sep 20, 2023
@andreaTP
Copy link
Contributor

@squakez I'll have a look 👍

@andreaTP
Copy link
Contributor

andreaTP commented Sep 20, 2023 •
edited
Loading

thinking about it: fixing this would be pretty straightforward, but my understanding is that license headers on each and every file are not a requirement anymore for Apache projects, cc. @oscerd

@oscerd
Copy link
Contributor

oscerd commented Sep 20, 2023

It's required for ASF projects

@oscerd
Copy link
Contributor

oscerd commented Sep 20, 2023

It's required for ASF projects as far as I know

@andreaTP
Copy link
Contributor

I'm sure it was, but I'm convinced it's not anymore.

@oscerd
Copy link
Contributor

oscerd commented Sep 20, 2023

Short license is still needed on top https://www.apache.org/legal/apply-license.html#new

@andreaTP
Copy link
Contributor

@oscerd given that this code is automatically generated, and, assuming this remains valid, I would add a LICENSE file in the ./java folder.

That said, I'm not fussy about it, if you still believe that it has to be done I can have a look.

@oscerd
Copy link
Contributor

oscerd commented Sep 20, 2023

For me it's the same. Thought @squakez ?

@squakez
Copy link
Contributor Author

squakez commented Sep 20, 2023

I'm good with that. In such case I can take care of adding that as we're already doing with CRDs files. I will also to change the check script, but I can work on it.

@andreaTP
Copy link
Contributor

Let me know if you need any support @squakez 👍

squakez added a commit to squakez/camel-k that referenced this issue Sep 21, 2023
@squakez
chore(ci): java licenses files
326c3ee 
Closes apache#4700
@squakez squakez linked a pull request Sep 21, 2023 that will close this issue
fix(ci): license check #4763
Merged
squakez added a commit that referenced this issue Sep 21, 2023
@squakez
fix(ci): license check
b16a649 
Ref #4700
squakez added a commit that referenced this issue Sep 21, 2023
@squakez
chore(ci): java licenses files
ca71603 
Closes #4700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squakez squakez

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): license check squakez/camel-k
3 participants
@oscerd @andreaTP @squakez