knative: add some checks about supported http methods and mandatory body #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 16, 2019
| HttpServerResponse response = request.response(); | ||
| response.setStatusCode(405); | ||
| response.putHeader(Exchange.CONTENT_TYPE, "text/plain"); | ||
| response.end("Unsupported method: " + request.method()); |
There was a problem hiding this comment.
Not sure if we need to ask people to manually set "POST" or we should do it for them.
They're sending data to a knative endpoint that wraps HTTP after all.
I'm thinking to simple bridging integrations:
rest().put("/person/{id}").to("knative:event/person")
There was a problem hiding this comment.
The component does it by default, in your case you want to "put" an event to the broker and the underlying transport implementation will hit a POST to the target knative service.
This check is on the consumer side to restrict the methods we support
nicolaferraro
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.