Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knative component switches from POST to GET depending on the presence of the exchange body #121

Closed
nicolaferraro opened this issue Jul 30, 2019 · 6 comments
Closed

Knative component switches from POST to GET depending on the presence of the exchange body #121

nicolaferraro opened this issue Jul 30, 2019 · 6 comments
Assignees
@lburgazzoli @nicolaferraro

Comments

@nicolaferraro
Copy link
Member

It should always use POST.
@lburgazzoli
Copy link
Contributor

@nicolaferraro can you check that this is solved with the latest code based on undertow ?

@lburgazzoli lburgazzoli self-assigned this Aug 2, 2019
@nicolaferraro nicolaferraro self-assigned this Aug 2, 2019
@nicolaferraro
Copy link
Member Author

Will write some integration tests

@nicolaferraro
Copy link
Member Author

Forcing the method to get, it seems to change it to POST, but I cannot post without a body.. it fails because null cannot be converted to []byte.

I think it's acceptable.

@lburgazzoli
Copy link
Contributor

I'll add an additional check to validate methods and body

@lburgazzoli
Copy link
Contributor

#161

@nicolaferraro
Copy link
Member Author

Verified in integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lburgazzoli lburgazzoli

@nicolaferraro nicolaferraro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lburgazzoli @nicolaferraro