Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Flaky flag to skip testBookieServerZKSessionExpireBehaviour test #4144

Merged

Conversation

hangc0276
Copy link
Contributor

Descriptions of the changes in this PR:

Motivation

The BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour is a flaky test and the root cause is described in #3418.

There is a race condition in the zookeeper reconnection and listener and it is an expected behavior in Bookie.

We created one issue to track this #4142.

We can skip this flaky test to unblock the pending PRs.

Changes

Skip this flaky test.

(Describe: what changes you have made)

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@hangc0276 hangc0276 changed the title Skip testBookieServerZKSessionExpireBehaviour test due to flaky Use Flaky flag to skip testBookieServerZKSessionExpireBehaviour test Dec 6, 2023
@zymap zymap merged commit 11ccebb into apache:master Dec 7, 2023
16 checks passed
zymap pushed a commit that referenced this pull request Dec 8, 2023
…4144)

### Motivation
The `BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour` is a flaky test and the root cause is described in #3418.

There is a race condition in the zookeeper reconnection and listener and it is an expected behavior in Bookie.

We created one issue to track this #4142.

We can skip this flaky test to unblock the pending PRs.

(cherry picked from commit 11ccebb)
yangl pushed a commit to yangl/bookkeeper that referenced this pull request Dec 11, 2023
…pache#4144)

### Motivation
The `BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour` is a flaky test and the root cause is described in apache#3418. 

There is a race condition in the zookeeper reconnection and listener and it is an expected behavior in Bookie.

We created one issue to track this apache#4142. 

We can skip this flaky test to unblock the pending PRs.
hangc0276 added a commit to hangc0276/bookkeeper that referenced this pull request Jan 18, 2024
…pache#4144)

### Motivation
The `BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour` is a flaky test and the root cause is described in apache#3418.

There is a race condition in the zookeeper reconnection and listener and it is an expected behavior in Bookie.

We created one issue to track this apache#4142.

We can skip this flaky test to unblock the pending PRs.

(cherry picked from commit 11ccebb)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
…pache#4144)

### Motivation
The `BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour` is a flaky test and the root cause is described in apache#3418. 

There is a race condition in the zookeeper reconnection and listener and it is an expected behavior in Bookie.

We created one issue to track this apache#4142. 

We can skip this flaky test to unblock the pending PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants