Skip to content

Commit

Permalink
Use Flaky flag to skip testBookieServerZKSessionExpireBehaviour test (#…
Browse files Browse the repository at this point in the history
…4144)

### Motivation
The `BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour` is a flaky test and the root cause is described in #3418.

There is a race condition in the zookeeper reconnection and listener and it is an expected behavior in Bookie.

We created one issue to track this #4142.

We can skip this flaky test to unblock the pending PRs.

(cherry picked from commit 11ccebb)
  • Loading branch information
hangc0276 authored and zymap committed Dec 8, 2023
1 parent 1fe42aa commit 827293c
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import lombok.extern.slf4j.Slf4j;
import org.apache.bookkeeper.bookie.MockUncleanShutdownDetection;
import org.apache.bookkeeper.bookie.TestBookieImpl;
import org.apache.bookkeeper.common.testing.annotations.FlakyTest;
import org.apache.bookkeeper.conf.ServerConfiguration;
import org.apache.bookkeeper.proto.BookieServer;
import org.apache.bookkeeper.stats.NullStatsLogger;
Expand Down Expand Up @@ -123,7 +124,7 @@ conf, new TestBookieImpl(conf),
Attempt to reconnect by BookieStateManager's RegistrationManager listener
will fail (even if retry it many times).
*/
@Test
@FlakyTest(value = "https://github.com/apache/bookkeeper/issues/4142")
@SuppressWarnings("deprecation")
public void testBookieServerZKSessionExpireBehaviour() throws Exception {
// 6000 is minimum due to default tick time
Expand Down

0 comments on commit 827293c

Please sign in to comment.