Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44273: [C++][Decimal] Use 0E+1 not 0.E+1 for broader compatibility #44275

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 1, 2024

Rationale for this change

Most environments such as Python, Node.js, PostgreSQL and MySQL accepts 0.E+1 but some environments such as Ruby don't accept 0.E+1. More environments accept 0.0E+1 or 0E+1 than 0.E+1.

What changes are included in this PR?

Use 0E+1 not 0.E+1 for broader compatibility.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Copy link

github-actions bot commented Oct 1, 2024

⚠️ GitHub issue #44273 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member

pitrou commented Oct 1, 2024

There are a lot of failing CI builds.

@kou
Copy link
Member Author

kou commented Oct 1, 2024

Oh, sorry. I needed to update more expected values...

kou added 3 commits October 2, 2024 09:45
…bility

Most environments such as Python, Node.js, PostgreSQL and MySQL
accepts `0.E+1` but some environments such as Ruby don't accept
`0.E+1`. More environments accept `0.0E+1` or `0E+1` than `0.E+1`.

Use `0E+1` not `0.E+1` for broader compatibility.
@kou kou force-pushed the cpp-decimal-not-omit-fractional branch from 887bd76 to 3f25f22 Compare October 2, 2024 00:45
@kou
Copy link
Member Author

kou commented Oct 4, 2024

I'll merge this in a few days if nobody objects this.

@kou kou merged commit d4516c5 into apache:main Oct 9, 2024
38 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 9, 2024
@kou kou deleted the cpp-decimal-not-omit-fractional branch October 9, 2024 01:09
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d4516c5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants