Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Decimal] Use 0E+1 not 0.E+1 for broader compatibility #44273

Closed
kou opened this issue Oct 1, 2024 · 2 comments
Closed

[C++][Decimal] Use 0E+1 not 0.E+1 for broader compatibility #44273

kou opened this issue Oct 1, 2024 · 2 comments
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@kou
Copy link
Member

kou commented Oct 1, 2024 •
edited
Loading

Describe the enhancement requested

The current decimal implementation omits the fractional part if the fractional part is 0.
For example: 0.E+1 not 0.0E+1

Most environments such as Python, Node.js, PostgreSQL and MySQL accepts 0.E+1 but some environments such as Ruby don't accept 0.E+1.

Can we use 0E+1 (or 0.0E+1) not 0.E+1 for broader compatibility?

See also: GH-43877

Component(s)

C++
@kou kou changed the title [C++][Decimal] Use 0.0E+1 not 0.E+1 for broader compatibility [C++][Decimal] Use 0E+1 not 0.E+1 for broader compatibility Oct 1, 2024
kou added a commit to kou/arrow that referenced this issue Oct 1, 2024
@kou
apacheGH-44273: [C++][Decimal] Use 0E+1 not 0.E+1 for broader compati…
bfc672f 
…bility

Most environments such as Python, Node.js, PostgreSQL and MySQL
accepts `0.E+1` but some environments such as Ruby don't accept
`0.E+1`. More environments accept `0.0E+1` or `0E+1` than `0.E+1`.

Use `0E+1` not `0.E+1` for broader compatibility.
@github-actions github-actions bot mentioned this issue Oct 1, 2024
Merged
kou added a commit to kou/arrow that referenced this issue Oct 2, 2024
@kou
apacheGH-44273: [C++][Decimal] Use 0E+1 not 0.E+1 for broader compati…
fde75c5 
…bility

Most environments such as Python, Node.js, PostgreSQL and MySQL
accepts `0.E+1` but some environments such as Ruby don't accept
`0.E+1`. More environments accept `0.0E+1` or `0E+1` than `0.E+1`.

Use `0E+1` not `0.E+1` for broader compatibility.
@kou
Copy link
Member Author

kou commented Oct 4, 2024

The discussion thread: https://lists.apache.org/thread/w5gymjbdc8c3ggh31lngt6o1dwjcjptd

kou added a commit that referenced this issue Oct 9, 2024
@kou
GH-44273: [C++][Decimal] Use 0E+1 not 0.E+1 for broader compatibility (…
d4516c5 
…#44275)

### Rationale for this change

Most environments such as Python, Node.js, PostgreSQL and MySQL accepts `0.E+1` but some environments such as Ruby don't accept `0.E+1`. More environments accept `0.0E+1` or `0E+1` than `0.E+1`.

### What changes are included in this PR?

Use `0E+1` not `0.E+1` for broader compatibility.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #44273

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Oct 9, 2024
@kou
Copy link
Member Author

kou commented Oct 9, 2024

Issue resolved by pull request 44275
#44275

@kou kou closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@kou