GH-43576: [Java] Gandiva Tests are failing due to linking issues #43978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lidavidm There are a very high number of test cases failing in the disabled test class. Instead of disabling each one, I disabled the class for now, but created a Github issue and tagged it in the disable message. |
danepitkin
approved these changes
Sep 9, 2024
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Sep 10, 2024
|
@danepitkin Yes, we need the Gandiva maintainers' support. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f3dd298. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 101 possible false positives for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…che#43978) ### Rationale for this change Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR? This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981 ### Are these changes tested? Yes, by existing CIs and tests. ### Are there any user-facing changes? No * GitHub Issue: #43576 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
zeroshade
pushed a commit
to zeroshade/arrow
that referenced
this pull request
Sep 30, 2024
…che#43978) ### Rationale for this change Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR? This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981 ### Are these changes tested? Yes, by existing CIs and tests. ### Are there any user-facing changes? No * GitHub Issue: #43576 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component.
What changes are included in this PR?
This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests.
Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981
Are these changes tested?
Yes, by existing CIs and tests.
Are there any user-facing changes?
No