-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Gandiva Tests are failing due to linking issues #63
Comments
apache/arrow#43639 (comment) This test also needs to be disabled. |
@praveenbingo @pravindra you seem to be the last committers to have worked on the Java part of Gandiva; do you have any idea about this issue? |
Most of the failing tests are due to the |
) ### Rationale for this change Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR? This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981 ### Are these changes tested? Yes, by existing CIs and tests. ### Are there any user-facing changes? No * GitHub Issue: #43576 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
@laurentgo do you have any colleagues who might know what's up with Gandiva? |
…che#43978) ### Rationale for this change Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR? This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981 ### Are these changes tested? Yes, by existing CIs and tests. ### Are there any user-facing changes? No * GitHub Issue: #43576 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
…che#43978) ### Rationale for this change Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR? This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981 ### Are these changes tested? Yes, by existing CIs and tests. ### Are there any user-facing changes? No * GitHub Issue: #43576 Authored-by: Vibhatha Lakmal Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
I've moved this to 19.0.0, let me know if this should be a blocker for the release. |
It's possible we're going to ship Gandiva in a known-broken state, so we should just highlight it in the release notes |
+1 for this. I think that makes sense and a sub optimal solution for the problem we have. |
Hi, I work with @laurentgo at Dremio and I've started looking into this issue. Let me know if there is a better format for this discussion (email vs GH issue, etc). I wanted to summarize some of the different threads and then talk about how I've worked around the issue here at Dremio. The test errors seem to all be "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" which is also tracked here, and a few causes and ideas for fixes are listed here and here for Python. I also found this issue regarding the symbols in the llvm project. The poster there believes that requiring the symbols is a bad design. I tend to agree but I'm not sure why it was done in the first place. The ORC symbol issue seems to stem from apache/arrow#37848. We haven't had this problem at Dremio because we actually reverted that change in our local repo after I found a few llvm expression related test failures. I asked about that here https://lists.apache.org/thread/xzrwx1t37dc88vo5yo5337l16ypqwcrd. I spent considerable time looking into this issue but was never able to track it down. I'm not sure what to do at this point. One idea is reverting the JIT upgrade while also following up with the llvm community on the symbol issue. @niyue Mentioned following up with them here, not sure if he found anything: apache/arrow#39695 (comment) |
Right. I think we can discuss the technical aspect of the issue here. FWIW, I would say it would be fine to get this to a release viable point by using an older version of an upgrade we have done so far. But I solely wouldn't be a judge for that. Really appreciate your support to look into this matter. |
@lriggs Regarding the LLVM 17 symbol issue, I recall investigating it previously. It stems from a design change introduced in LLVM 17, and unfortunately, there doesn't appear to be an easy fix at that time. A related issue has been logged here: LLVM Project Issue #74671. |
Describe the bug, including details regarding any error messages, version, and platform.
At the moment, java-jars CI in Arrow Java is failing due to a Gandiva issue. This CI in green is much needed to determine the accuracy of certain PRs to Java. In order to keep it green, as discussed we are disabling the failing Gandiva tests temporarily. But needs to be re-enabled once the LLVM related issue is resolved.
Component(s)
Java
The text was updated successfully, but these errors were encountered: