Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43232: [Release][Packaging][Python] Add tzdata as conda env requirement to avoid ORC failure #43233

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 12, 2024

Rationale for this change

Binary verifications for wheels on conda are failing on ORC test due to missing tzdata

What changes are included in this PR?

Adding tzdata as conda requirement when setting up the environment on the verification script

Are these changes tested?

Those changes have been tested locally

Are there any user-facing changes?

No

@raulcd raulcd requested review from assignUser and kou as code owners July 12, 2024 09:59
@raulcd raulcd requested a review from wgtmac July 12, 2024 09:59
Copy link

⚠️ GitHub issue #43232 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 12, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit bafb2d8 into apache:main Jul 12, 2024
7 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jul 12, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 12, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bafb2d8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants