[Packaging][Release][Python] Binary verification of wheels on conda is segfaulting on ORC test_example_using_json #43232
Comments
github-actions
bot
added
Component: Python
Component: Packaging
Component: Release
labels
|
This is a single test on a single job failing for the release. I am also not sure if we want to block the release for this one, @jorisvandenbossche @AlenkaF FYI |
|
Can we get a backtrace by |
|
What's the version of ORC? I'm not sure if it is related to apache/orc#1882 @h-vetinari Does it mean we have to install |
The wheel was built with: |
|
Yes, the commit in doubt is included in the 2.0.1 release. |
|
Could you try this? diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index fcaaa423a4..bd136054e4 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -1153,7 +1153,7 @@ test_linux_wheels() {
local pyver=${python/m}
for platform in ${platform_tags}; do
show_header "Testing Python ${pyver} wheel for platform ${platform}"
- CONDA_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda
+ CONDA_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda tzdata
if ! VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv; then
continue
fi |
|
Thanks @kou ! That fixes the issue |
…requirement to avoid ORC failure
|
So ORC C++ still segfaults when it cannot find a timezone database? I thought that had been fixed @wgtmac |
It is fixed in apache/orc#1893 by @ffacs and released with v2.0.1. This segfault was caused by reading |
…ement to avoid ORC failure (#43233) ### Rationale for this change Binary verifications for wheels on conda are failing on ORC test due to missing tzdata ### What changes are included in this PR? Adding tzdata as conda requirement when setting up the environment on the verification script ### Are these changes tested? Those changes have been tested locally ### Are there any user-facing changes? No * GitHub Issue: #43232 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
Issue resolved by pull request 43233 |
I think that ORC C++ should not segfault for the case. |
|
Yes, regardless of who's responsible ;-), we should definitely not segfault when trying to read a valid ORC file (or even an invalid one, actually). |
|
Yes, we should not segfault in this case. I think we are missing a Let me fix this and check other lines as well. |
Describe the bug, including details regarding any error messages, version, and platform.
The verify-rc-binaries-wheels-linux-conda-latest-amd64 segfaults on
test_example_using_jsonwhen checking the file:This can be reproduced locally with
archery docker run -e VERIFY_VERSION="17.0.0" -e VERIFY_RC="2" -e TEST_DEFAULT=0 -e TEST_WHEELS=1 conda-verify-rc. This is the only test failing as I can have a successful verification with the following local change:Component(s)
Packaging, Python, Release
The text was updated successfully, but these errors were encountered: