GH-42002: [Java] Update Unit Tests for Vector Module #42019
Conversation
- Before -> BeforeEach - BeforeClass -> BeforeAll - After -> AfterEach - AfterClass -> AfterAll - Test -> Test
|
|
|
@llama90 I will review this later today. |
|
@vibhatha Thanks! I'll try to review it myself before your review. |
|
@llama90 wonderful! Ping me once you're ready. Thanks. |
There was a problem hiding this comment.
Approach LGTM! Thanks for the improvement.
There was a problem hiding this comment.
Yep, this one too. Thanks.
| @@ -154,9 +152,6 @@ public void testSchemaDictionaryMessageSerialization() throws IOException { | |||
| assertEquals(schema, deserialized); | |||
| } | |||
|
|
|||
| @Rule | |||
| public ExpectedException expectedEx = ExpectedException.none(); | |||
There was a problem hiding this comment.
Is this code really unused?
There was a problem hiding this comment.
The test that used it was added 7 years ago and since removed, so it appears so.
github-actions
bot
added
awaiting committer review
| @@ -154,9 +152,6 @@ public void testSchemaDictionaryMessageSerialization() throws IOException { | |||
| assertEquals(schema, deserialized); | |||
| } | |||
|
|
|||
| @Rule | |||
| public ExpectedException expectedEx = ExpectedException.none(); | |||
There was a problem hiding this comment.
The test that used it was added 7 years ago and since removed, so it appears so.
github-actions
bot
added
awaiting merge
java/vector/src/test/java/org/apache/arrow/vector/TestLargeVarCharVector.java
Outdated
Show resolved
Hide resolved
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit fe4d04f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Update package from JUnit 4(
org.junit) to JUnit 5(org.junit.jupiter).What changes are included in this PR?
org.junitwithorg.junit.jupiter.api.Assertions.assertXXXtoassertXXXusing static imports.@Before,@BeforeClass,@After,@AfterClass.@Before->@BeforeEach@BeforeClass->@BeforeAll@After->@AfterEach@AfterClass->@AfterAll@Test->@Testwithorg.junit.jupiter@RuleAnnotationParameterizedtestAre these changes tested?
Yes, existing tests have passed.
Are there any user-facing changes?
No.