Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Update Unit Tests for Vector Module #42002

Closed
Tracked by #41680
llama90 opened this issue Jun 6, 2024 · 4 comments
Closed
Tracked by #41680

[Java] Update Unit Tests for Vector Module #42002

llama90 opened this issue Jun 6, 2024 · 4 comments
Assignees
@llama90
Labels
Component: Java Type: enhancement
Milestone
17.0.0

Comments

@llama90
Copy link
Contributor

llama90 commented Jun 6, 2024

Describe the enhancement requested

This is a sub-issue of the issue below.

The unit tests should use the org.junit.jupiter.api package. This issue deals with the vector module.

Component(s)

Java
@vibhatha
Copy link
Collaborator

vibhatha commented Jun 6, 2024

@llama90 would you like to contribute a PR?

@llama90
Copy link
Contributor Author

llama90 commented Jun 6, 2024

Yes, I would. I have a plan to follow these steps:

  1. Replace org.junit with org.junit.jupiter.api.
  2. Update no suitable method found for assertEquals (string, xxx, yyy) to (xxx, yyy, string) because in JUnit 5, the "message field" has changed.
  3. Update Assertions.assertXXX to assertXXX using static imports.
    • I believe using static imports will make the code base clearer.
  4. Update annotations such as @Before, @BeforeClass, @After, @AfterClass, etc., to their JUnit 5 equivalents.
  5. ...
  6. In the final step, replace junit-vintage-engine with junit-jupiter-engine to prevent using JUnit 4 statements.
    • Maybe, it should be changed after all JUnit 4 statements are removed.

Additionally, I will review documentation like Migrating from JUnit 4 to JUnit 5.

Let me know if you have any suggestions or additional steps.

@vibhatha
Copy link
Collaborator

vibhatha commented Jun 6, 2024

Sounds like a plan! Looking forward to it.

@github-actions github-actions bot mentioned this issue Jun 6, 2024
Merged
6 tasks
@vibhatha vibhatha mentioned this issue Jun 7, 2024
Closed
12 tasks
lidavidm pushed a commit that referenced this issue Jun 7, 2024
@llama90
GH-42002: [Java] Update Unit Tests for Vector Module (#42019)
fe4d04f 
### Rationale for this change

Update package from JUnit 4(`org.junit`) to JUnit 5(`org.junit.jupiter`).

### What changes are included in this PR?

- [x] Replacing `org.junit` with `org.junit.jupiter.api`.
- [x] Updating `Assertions.assertXXX` to `assertXXX` using static imports.
- [x] Updating annotations such as `@ Before`, `@ BeforeClass`, `@ After`, `@ AfterClass`.
  - `@ Before` -> `@ BeforeEach`
  - `@ BeforeClass` -> `@ BeforeAll`
  - `@ After` -> `@ AfterEach`
  - `@ AfterClass` -> `@ AfterAll`
  - `@ Test` -> `@ Test` with `org.junit.jupiter`
- [x] Removing unused `@ Rule` Annotation
- [x] Updating `Parameterized` test
- [x] Doing self review

### Are these changes tested?

Yes, existing tests have passed.

### Are there any user-facing changes?

No.

* GitHub Issue: #42002

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm lidavidm added this to the 17.0.0 milestone Jun 7, 2024
@lidavidm
Copy link
Member

lidavidm commented Jun 7, 2024

Issue resolved by pull request 42019
#42019

@lidavidm lidavidm closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llama90 llama90

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
3 participants
@lidavidm @llama90 @vibhatha