Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40727: [C++][Gandiva] 'ilike' function does not work #40728

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

lriggs
Copy link
Contributor

@lriggs lriggs commented Mar 22, 2024

Rationale for this change

Bug fix for GH-40727

What changes are included in this PR?

Register the 'ilike' function.
Added unit test.

Are these changes tested?

Yes, unit test.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #40727 has been automatically assigned in GitHub to PR creator.

cpp/src/gandiva/tests/utf8_test.cc Outdated Show resolved Hide resolved
cpp/src/gandiva/tests/utf8_test.cc Outdated Show resolved Hide resolved
cpp/src/gandiva/tests/utf8_test.cc Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Mar 22, 2024
@github-actions github-actions bot added Component: Java awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 22, 2024
@lidavidm
Copy link
Member

Can you rebase again? This has picked up unrelated changes

@lriggs
Copy link
Contributor Author

lriggs commented Mar 22, 2024

Can you rebase again? This has picked up unrelated changes

Trying to, not sure how these got in there.

@lidavidm lidavidm removed their request for review March 22, 2024 15:52
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit d96fc69 into apache:main Mar 22, 2024
29 of 33 checks passed
@kou kou removed the awaiting change review Awaiting change review label Mar 22, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 22, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d96fc69.

There were 2 benchmark results with an error:

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants