-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40727: [C++][Gandiva] 'ilike' function does not work #40728
Conversation
|
Can you rebase again? This has picked up unrelated changes |
Trying to, not sure how these got in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d96fc69. There were 2 benchmark results with an error:
There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Bug fix for GH-40727
What changes are included in this PR?
Register the 'ilike' function.
Added unit test.
Are these changes tested?
Yes, unit test.
Are there any user-facing changes?
No.