Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gandiva] 'ilike' function does not work #40727

Closed
lriggs opened this issue Mar 22, 2024 · 2 comments
Closed

[Gandiva] 'ilike' function does not work #40727

lriggs opened this issue Mar 22, 2024 · 2 comments
Assignees
@lriggs
Labels
Component: C++ Component: Gandiva Type: bug
Milestone
16.0.0

Comments

@lriggs
Copy link
Contributor

lriggs commented Mar 22, 2024

Describe the bug, including details regarding any error messages, version, and platform.

When you attempt to use the 'ilike' function in Gandiva you get an error:
function holder not registered for function ilike

It seems some refactoring missed adding ilike to the function holder registry. This is a regression from Arrow 14.

A simple way to see the error is to add another test case in cpp/src/gandiva/tests/utf8_test.cc for ilike (by copying the existing 'like' test).

Component(s)

C++, C++ - Gandiva
lriggs added a commit to lriggs/arrow that referenced this issue Mar 22, 2024
@lriggs
apacheGH-40727: 'ilike' function does not work
1db8b45
@lriggs lriggs mentioned this issue Mar 22, 2024
Merged
@kou kou changed the title 'ilike' function does not work [Gandiva] 'ilike' function does not work Mar 22, 2024
@kou
Copy link
Member

kou commented Mar 22, 2024

Oh, #38632 removed the ilike entry accidentally...

lriggs added a commit to lriggs/arrow that referenced this issue Mar 22, 2024
@lriggs
apacheGH-40727: 'ilike' function does not work
eff81f0
kou pushed a commit that referenced this issue Mar 22, 2024
@lriggs
GH-40727: [C++][Gandiva] 'ilike' function does not work (#40728)
d96fc69 
### Rationale for this change

Bug fix for GH-40727

### What changes are included in this PR?

Register the 'ilike' function.
Added unit test.

### Are these changes tested?

Yes, unit test.

### Are there any user-facing changes?

No.

* GitHub Issue: #40727

Authored-by: Logan Riggs <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 16.0.0 milestone Mar 22, 2024
@kou
Copy link
Member

kou commented Mar 22, 2024

Issue resolved by pull request 40728
#40728

@kou kou closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lriggs lriggs

Labels
Component: C++ Component: Gandiva Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@kou @lriggs