-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39737: [Release][Docs] Update post release documentation task #39762
Conversation
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Just to confirm, did you try this change?
FYI: You can use dry-run by PUSH=0 dev/release/post-08-docs.sh VERSION PREVIOUS_VERSION
.
No didn't try, had no idea how to :) Will do as you suggest, thank you! And if it looks good locally, I will go ahead and merge. |
@kou, can the post release tasks be run (or dry-run) on MacOS? |
Yes. It should work on macOS. Because a release manager may use macOS. Did you get any error? |
Yes, sorry:
|
Oh, could you try the following? diff --git a/dev/release/post-08-docs.sh b/dev/release/post-08-docs.sh
index f18f7d10c7..a7529fdb2f 100755
--- a/dev/release/post-08-docs.sh
+++ b/dev/release/post-08-docs.sh
@@ -45,7 +45,16 @@ esac
pushd "${ARROW_SITE_DIR}"
source "${SOURCE_DIR}/git-vars.sh"
-git fetch --all --prune --tags --force -j$(nproc)
+n_cpus=1
+case $(uname) in
+ Linux)
+ n_cpus=$(nproc)
+ ;;
+ Darwin)
+ n_cpus=$(sysctl -n hw.logicalcpu)
+ ;;
+esac
+git fetch --all --prune --tags --force -j${n_cpus}
git checkout .
git checkout ${DEFAULT_BRANCH}
git clean -d -f -x |
The suggested change fixes the issue 👍 I am dealing with next error currently:
Tried adding a fresh clone of
|
Hmm. Could you enable trace log by |
Sure. It still just hangs. Something with my connection to GitHub I guess?
|
Ah, you need to enter your passphrase for |
Yes, I did. First time it worked, now it gets stuck every time ... |
Ha, I tried hitting enter again (twice that is) and got:
I just started using ssh key with github so need to check why it is not working. Sorry for the spam! |
No problem. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested locally and there is one change required (previous_series
instead of previous_version
) and a couple minor changes in order to split the commits in two so it's easier if we require to review them.
Co-authored-by: Raúl Cumplido <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with PUSH=0
and it works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 874e596. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
apache#39762) This PR updates the `dev/release/post-08-docs.sh` task so that - `DOCUMENTATION_OPTIONS.theme_switcher_version_match` changes from `""` to `"{previous_version}"` - `DOCUMENTATION_OPTIONS.show_version_warning_banner` changes from `false` to `true` for the documentation that is moved to a subfolder when a new major release is done. * Closes: apache#39737 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
) This PR updates the `dev/release/post-08-docs.sh` task so that - `DOCUMENTATION_OPTIONS.theme_switcher_version_match` changes from `""` to `"{previous_version}"` - `DOCUMENTATION_OPTIONS.show_version_warning_banner` changes from `false` to `true` for the documentation that is moved to a subfolder when a new major release is done. * Closes: #39737 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
apache#39762) This PR updates the `dev/release/post-08-docs.sh` task so that - `DOCUMENTATION_OPTIONS.theme_switcher_version_match` changes from `""` to `"{previous_version}"` - `DOCUMENTATION_OPTIONS.show_version_warning_banner` changes from `false` to `true` for the documentation that is moved to a subfolder when a new major release is done. * Closes: apache#39737 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
apache#39762) This PR updates the `dev/release/post-08-docs.sh` task so that - `DOCUMENTATION_OPTIONS.theme_switcher_version_match` changes from `""` to `"{previous_version}"` - `DOCUMENTATION_OPTIONS.show_version_warning_banner` changes from `false` to `true` for the documentation that is moved to a subfolder when a new major release is done. * Closes: apache#39737 Lead-authored-by: AlenkaF <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This PR updates the
dev/release/post-08-docs.sh
task so thatDOCUMENTATION_OPTIONS.theme_switcher_version_match
changes from""
to"{previous_version}"
DOCUMENTATION_OPTIONS.show_version_warning_banner
changes fromfalse
totrue
for the documentation that is moved to a subfolder when a new major release is done.