Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release][Docs] Changes for version and warning banner should not affect minor releases #40458

Closed
AlenkaF opened this issue Mar 11, 2024 · 1 comment

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Mar 11, 2024

Describe the bug, including details regarding any error messages, version, and platform.

The change we added in #39762 also affects the docs being built for minor releases but since these are not moved to a separate folder they should not include the change - neither for DOCUMENTATION_OPTIONS.theme_switcher_version_match nor for DOCUMENTATION_OPTIONS.show_version_warning_banner.

We should make sure the change in version and warning banner only affects major releases.

Component(s)

Documentation, Release

@AlenkaF AlenkaF self-assigned this Mar 11, 2024
AlenkaF added a commit that referenced this issue Mar 12, 2024
…ld not affect minor releases (#40459)

This PR adds an if case to me make sure the change in version and warning banner only affects major releases.
* GitHub Issue: #40458

Authored-by: AlenkaF <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 13, 2024

Closed by #40459

@AlenkaF AlenkaF closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant