GH-38293: [R] Fix non-deterministic duckdb test #38294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
|
@github-actions crossbow submit test-r-rstudio-r-base-4.2-centos7-devtoolset-8 |
|
Revision: 1b4f681 Submitted crossbow builds: ursacomputing/crossbow @ actions-de322a4fe4
|
thisisnic
approved these changes
Oct 16, 2023
github-actions
bot
added
awaiting merge
raulcd
pushed a commit
that referenced
this pull request
Oct 17, 2023
### Rationale for this change The test fail with the latest version of duckdb (0.9.1). ### What changes are included in this PR? The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: #38293 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b3b958e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
### Rationale for this change The test fail with the latest version of duckdb (0.9.1). ### What changes are included in this PR? The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#38293 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change The test fail with the latest version of duckdb (0.9.1). ### What changes are included in this PR? The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#38293 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The test fail with the latest version of duckdb (0.9.1). ### What changes are included in this PR? The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#38293 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The test fail with the latest version of duckdb (0.9.1).
What changes are included in this PR?
The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb.
Are these changes tested?
Yes
Are there any user-facing changes?
No