Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] duckdb tests fail with duckdb 0.9.1 #38293

Closed
paleolimbot opened this issue Oct 16, 2023 · 0 comments · Fixed by #38294
Closed

[R] duckdb tests fail with duckdb 0.9.1 #38293

paleolimbot opened this issue Oct 16, 2023 · 0 comments · Fixed by #38294
Assignees
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Milestone

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

With duckdb 0.9.1 we now see:


── Failure (test-duckdb.R:243:3): to_duckdb with a table ───────────────────────
... %>% collect() (`actual`) not identical to tibble::tibble(...) (`expected`).

actual vs expected
                int > 4 int_mean dbl_mean
  actual[1, ]     FALSE      2.0      2.1
- actual[2, ]      TRUE      7.5      7.3
+ expected[2, ]      NA       NA      4.1
- actual[3, ]        NA       NA      4.1
+ expected[3, ]    TRUE      7.5      7.3

`actual$int > 4`:   FALSE TRUE <NA>
`expected$int > 4`: FALSE <NA> TRUE

  `actual$int_mean`: 2  8 NA
`expected$int_mean`: 2 NA  8

  `actual$dbl_mean`: 2 7 4
`expected$dbl_mean`: 2 4 7

I will do a few more investigations to see if this is an arrow problem exposed via a duckdb update or a duckdb problem.

Component(s)

R

@paleolimbot paleolimbot added Type: bug Priority: Blocker Marks a blocker for the release labels Oct 16, 2023
paleolimbot added a commit that referenced this issue Oct 17, 2023
### Rationale for this change

The test fail with the latest version of duckdb (0.9.1).

### What changes are included in this PR?

The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #38293

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@paleolimbot paleolimbot added this to the 14.0.0 milestone Oct 17, 2023
raulcd pushed a commit that referenced this issue Oct 17, 2023
### Rationale for this change

The test fail with the latest version of duckdb (0.9.1).

### What changes are included in this PR?

The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #38293

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
### Rationale for this change

The test fail with the latest version of duckdb (0.9.1).

### What changes are included in this PR?

The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#38293

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
### Rationale for this change

The test fail with the latest version of duckdb (0.9.1).

### What changes are included in this PR?

The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#38293

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
### Rationale for this change

The test fail with the latest version of duckdb (0.9.1).

### What changes are included in this PR?

The test was changed so that it did not depend on non-deterministic behaviour. We sort all of the other expectations involving a group_by to avoid this problem...we hadn't changed this one yet because it didn't fail in any previous version of duckdb.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#38293

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant