-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38153: [C#] expose ArrayDataConcatenator.Concatenate #38154
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
{ | ||
internal static ArrayData Concatenate(IReadOnlyList<ArrayData> arrayDataList, MemoryAllocator allocator = default) | ||
public static ArrayData Concatenate(IReadOnlyList<ArrayData> arrayDataList, MemoryAllocator allocator = default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this instead of (or "and not also") ArrowArrayConcatenator.Concatenate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in addition to that. That was done last week and this was missed.
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e74d3a9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…#38154) ### Rationale for this change New C# drivers need the ability to concatenate array data, particularly for metadata calls. ### What changes are included in this PR? Converts a previously internal class and method to a public class and method. ### Are these changes tested? Yes ### Are there any user-facing changes? It exposes previously hidden functionality. Resolves apache#38153 * Closes: apache#38153 Lead-authored-by: David Coe <[email protected]> Co-authored-by: davidhcoe <[email protected]> Signed-off-by: David Li <[email protected]>
…#38154) ### Rationale for this change New C# drivers need the ability to concatenate array data, particularly for metadata calls. ### What changes are included in this PR? Converts a previously internal class and method to a public class and method. ### Are these changes tested? Yes ### Are there any user-facing changes? It exposes previously hidden functionality. Resolves apache#38153 * Closes: apache#38153 Lead-authored-by: David Coe <[email protected]> Co-authored-by: davidhcoe <[email protected]> Signed-off-by: David Li <[email protected]>
…#38154) ### Rationale for this change New C# drivers need the ability to concatenate array data, particularly for metadata calls. ### What changes are included in this PR? Converts a previously internal class and method to a public class and method. ### Are these changes tested? Yes ### Are there any user-facing changes? It exposes previously hidden functionality. Resolves apache#38153 * Closes: apache#38153 Lead-authored-by: David Coe <[email protected]> Co-authored-by: davidhcoe <[email protected]> Signed-off-by: David Li <[email protected]>
Rationale for this change
New C# drivers need the ability to concatenate array data, particularly for metadata calls.
What changes are included in this PR?
Converts a previously internal class and method to a public class and method.
Are these changes tested?
Yes
Are there any user-facing changes?
It exposes previously hidden functionality.
Resolves #38153