Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37651: [C#] expose ArrowArrayConcatenator.Concatenate #37652

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

davidhcoe
Copy link
Contributor

@davidhcoe davidhcoe commented Sep 11, 2023

Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls.

What changes are included in this PR?

Converts a previously internal class and method to a public class and method.

Are these changes tested?

No substantive product changes were made. All tests still pass.

Are there any user-facing changes?

It exposes previously hidden functionality.

Resolves #37651

@github-actions
Copy link

⚠️ GitHub issue #37651 has been automatically assigned in GitHub to PR creator.

@davidhcoe
Copy link
Contributor Author

@lidavidm - can you help with this one?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 6, 2023
@lidavidm
Copy link
Member

lidavidm commented Oct 6, 2023

Looks like there's test failures/you may want to rebase or merge?

@lidavidm
Copy link
Member

lidavidm commented Oct 6, 2023

Oh, I guess this has to be updated to remove BindingFlags.NonPublic?

private static readonly MethodInfo s_concatenateInfo = typeof(ArrayData).Assembly.GetType("Apache.Arrow.ArrowArrayConcatenator")
.GetMethod("Concatenate", BindingFlags.Static | BindingFlags.NonPublic);

@lidavidm
Copy link
Member

lidavidm commented Oct 6, 2023

Or really: presumably reflection is no longer required for this test

@davidhcoe
Copy link
Contributor Author

Or really: presumably reflection is no longer required for this test

good catch. I will fix the test.

@lidavidm lidavidm merged commit 0d89741 into apache:main Oct 6, 2023
9 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Oct 6, 2023
@davidhcoe davidhcoe deleted the dev/expose-buildarray branch October 6, 2023 22:18
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 0d89741.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
…e#37652)

### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves apache#37651 

* Closes: apache#37651

Lead-authored-by: David Coe <[email protected]>
Co-authored-by: davidhcoe <[email protected]>
Signed-off-by: David Li <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…e#37652)

### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves apache#37651 

* Closes: apache#37651

Lead-authored-by: David Coe <[email protected]>
Co-authored-by: davidhcoe <[email protected]>
Signed-off-by: David Li <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…e#37652)

### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves apache#37651 

* Closes: apache#37651

Lead-authored-by: David Coe <[email protected]>
Co-authored-by: davidhcoe <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Expose ArrowArrayConcatenator.Concatenate
2 participants