-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37934: [Doc][Integration] Document C Data Interface testing #37935
Conversation
@github-actions crossbow submit preview-docs |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, just a few nits
@github-actions crossbow submit preview-docs |
Revision: 1368d28 Submitted crossbow builds: ursacomputing/crossbow @ actions-ec09d2921f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not being super familiar with this, but I find everything clearly explained to me
21fd4ae
to
1368d28
Compare
…pache#37935) ### Rationale for this change apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated. ### What changes are included in this PR? Add documentation for C Data Interface integration testing. ### Are these changes tested? N/A, only doc changes. ### Are there any user-facing changes? No. * Closes: apache#37934 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e9730f5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pache#37935) ### Rationale for this change apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated. ### What changes are included in this PR? Add documentation for C Data Interface integration testing. ### Are these changes tested? N/A, only doc changes. ### Are there any user-facing changes? No. * Closes: apache#37934 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…pache#37935) ### Rationale for this change apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated. ### What changes are included in this PR? Add documentation for C Data Interface integration testing. ### Are these changes tested? N/A, only doc changes. ### Are there any user-facing changes? No. * Closes: apache#37934 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…pache#37935) ### Rationale for this change apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated. ### What changes are included in this PR? Add documentation for C Data Interface integration testing. ### Are these changes tested? N/A, only doc changes. ### Are there any user-facing changes? No. * Closes: apache#37934 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…pache#37935) ### Rationale for this change apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated. ### What changes are included in this PR? Add documentation for C Data Interface integration testing. ### Are these changes tested? N/A, only doc changes. ### Are there any user-facing changes? No. * Closes: apache#37934 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Rationale for this change
gh-37537 added integration testing for the C Data Interface, but the documentation was not updated.
What changes are included in this PR?
Add documentation for C Data Interface integration testing.
Are these changes tested?
N/A, only doc changes.
Are there any user-facing changes?
No.