Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37934: [Doc][Integration] Document C Data Interface testing #37935

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 28, 2023

Rationale for this change

gh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

What changes are included in this PR?

Add documentation for C Data Interface integration testing.

Are these changes tested?

N/A, only doc changes.

Are there any user-facing changes?

No.

@pitrou
Copy link
Member Author

pitrou commented Sep 28, 2023

@github-actions crossbow submit preview-docs

@github-actions

This comment was marked as outdated.

Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, just a few nits

docs/source/format/Integration.rst Show resolved Hide resolved
docs/source/format/Integration.rst Outdated Show resolved Hide resolved
docs/source/format/Integration.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Sep 28, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 28, 2023
@pitrou
Copy link
Member Author

pitrou commented Sep 28, 2023

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: 1368d28

Submitted crossbow builds: ursacomputing/crossbow @ actions-ec09d2921f

Task Status
preview-docs Github Actions

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being super familiar with this, but I find everything clearly explained to me

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Sep 28, 2023
@pitrou pitrou force-pushed the gh-37934-doc-integ-c-data branch from 21fd4ae to 1368d28 Compare September 28, 2023 15:11
@pitrou pitrou merged commit e9730f5 into apache:main Sep 28, 2023
14 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Sep 28, 2023
@pitrou pitrou deleted the gh-37934-doc-integ-c-data branch September 28, 2023 16:24
etseidl pushed a commit to etseidl/arrow that referenced this pull request Sep 28, 2023
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e9730f5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc][Integration] Document C Data Interface testing
3 participants