Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration] Add C Data Interface integration testing #37537

Closed
pitrou opened this issue Sep 4, 2023 · 0 comments · Fixed by #37769
Closed

[Integration] Add C Data Interface integration testing #37537

pitrou opened this issue Sep 4, 2023 · 0 comments · Fixed by #37769
Assignees
@pitrou
Labels
Component: Integration Type: enhancement
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Sep 4, 2023

Describe the enhancement requested

We currently test C Data Interface compatibility in an ad hoc way, leading to issues such as gh-37056.

We should add systematic integration tests between implementations as we already do for IPC and Flight.

Component(s)

Integration
@pitrou pitrou self-assigned this Sep 4, 2023
@pitrou pitrou mentioned this issue Sep 6, 2023
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 18, 2023
@pitrou
apacheGH-37537: [Integration][C++] Add C Data Interface integration t…
442d971 
…esting
pitrou added a commit to pitrou/arrow that referenced this issue Sep 18, 2023
@pitrou
apacheGH-37537: [Integration][C++] Add C Data Interface integration t…
ce9186f 
…esting
@github-actions github-actions bot mentioned this issue Sep 18, 2023
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 18, 2023
@pitrou
apacheGH-37537: [Integration][C++] Add C Data Interface integration t…
92cb90e 
…esting
pitrou added a commit to pitrou/arrow that referenced this issue Sep 19, 2023
@pitrou
apacheGH-37537: [Integration][C++] Add C Data Interface integration t…
74aebdb 
…esting
pitrou added a commit that referenced this issue Sep 19, 2023
@pitrou @wjones127
GH-37537: [Integration][C++] Add C Data Interface integration testing (…
3b646ad 
…#37769)

### Rationale for this change

Currently there are no systematic integration tests between implementations of the C Data Interface, only a couple ad-hoc tests.

### What changes are included in this PR?

1. Add Archery infrastructure for integration testing of the C Data Interface
2. Add implementation of this interface for Arrow C++

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.
* Closes: #37537

Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Will Jones <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 14.0.0 milestone Sep 19, 2023
@pitrou pitrou mentioned this issue Sep 19, 2023
Closed
This was referenced Sep 27, 2023
Closed
Closed
Closed
Merged
Closed
pitrou added a commit that referenced this issue Sep 28, 2023
@pitrou
GH-37934: [Doc][Integration] Document C Data Interface testing (#37935)
e9730f5 
### Rationale for this change

gh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: #37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
etseidl pushed a commit to etseidl/arrow that referenced this issue Sep 28, 2023
@pitrou @etseidl
apacheGH-37934: [Doc][Integration] Document C Data Interface testing (a…
822c35a 
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou mentioned this issue Oct 19, 2023
Open
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@pitrou
apacheGH-37934: [Doc][Integration] Document C Data Interface testing (a…
b055e28 
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@pitrou
apacheGH-37934: [Doc][Integration] Document C Data Interface testing (a…
026b3fe 
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@pitrou @wjones127 @loicalleyne
apacheGH-37537: [Integration][C++] Add C Data Interface integration t…
0e2e863 
…esting (apache#37769)

### Rationale for this change

Currently there are no systematic integration tests between implementations of the C Data Interface, only a couple ad-hoc tests.

### What changes are included in this PR?

1. Add Archery infrastructure for integration testing of the C Data Interface
2. Add implementation of this interface for Arrow C++

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.
* Closes: apache#37537

Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Will Jones <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@pitrou @loicalleyne
apacheGH-37934: [Doc][Integration] Document C Data Interface testing (a…
a7e48ca 
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @wjones127 @dgreiss
apacheGH-37537: [Integration][C++] Add C Data Interface integration t…
7ba5694 
…esting (apache#37769)

### Rationale for this change

Currently there are no systematic integration tests between implementations of the C Data Interface, only a couple ad-hoc tests.

### What changes are included in this PR?

1. Add Archery infrastructure for integration testing of the C Data Interface
2. Add implementation of this interface for Arrow C++

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.
* Closes: apache#37537

Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Will Jones <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
apacheGH-37934: [Doc][Integration] Document C Data Interface testing (a…
daf2d13 
…pache#37935)

### Rationale for this change

apachegh-37537 added integration testing for the C Data Interface, but the documentation was not updated.

### What changes are included in this PR?

Add documentation for C Data Interface integration testing.

### Are these changes tested?

N/A, only doc changes.

### Are there any user-facing changes?

No.
* Closes: apache#37934

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Integration Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37537: [Integration][C++] Add C Data Interface integration testing pitrou/arrow
1 participant
@pitrou