Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [R] ARROW_ACERO should be ON by default in bundled build #35407

Merged
merged 1 commit into from
May 5, 2023
Merged

MINOR: [R] ARROW_ACERO should be ON by default in bundled build #35407

merged 1 commit into from
May 5, 2023

Conversation

nealrichardson
Copy link
Member

To match ARROW_DATASET. Without this, the default CRAN version on Linux won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission. cc @thisisnic

thisisnic
thisisnic approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 3, 2023
@thisisnic thisisnic mentioned this pull request May 3, 2023
Closed
44 tasks
@nealrichardson nealrichardson merged commit c2f7d13 into apache:main May 5, 2023
@nealrichardson nealrichardson deleted the nealrichardson-patch-1 branch May 5, 2023 14:04
@ursabot
Copy link

ursabot commented May 5, 2023

Benchmark runs are scheduled for baseline = 7432cc7 and contender = c2f7d13. c2f7d13 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.15% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c2f7d13e ec2-t3-xlarge-us-east-2
[Failed] c2f7d13e test-mac-arm
[Finished] c2f7d13e ursa-i9-9960x
[Failed] c2f7d13e ursa-thinkcentre-m75q
[Finished] 7432cc7f ec2-t3-xlarge-us-east-2
[Finished] 7432cc7f test-mac-arm
[Finished] 7432cc7f ursa-i9-9960x
[Finished] 7432cc7f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@nealrichardson @liujiacheng777
MINOR: [R] ARROW_ACERO should be ON by default in bundled build (apac…
4121c0b 
…he#35407)

To match ARROW_DATASET. Without this, the default CRAN version on Linux
won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission.
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@nealrichardson @ArgusLi
MINOR: [R] ARROW_ACERO should be ON by default in bundled build (apac…
8fe4b93 
…he#35407)

To match ARROW_DATASET. Without this, the default CRAN version on Linux
won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission.
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@nealrichardson @rtpsw
MINOR: [R] ARROW_ACERO should be ON by default in bundled build (apac…
612b19a 
…he#35407)

To match ARROW_DATASET. Without this, the default CRAN version on Linux
won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnic thisisnic thisisnic approved these changes

@paleolimbot paleolimbot Awaiting requested review from paleolimbot

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nealrichardson @ursabot @thisisnic