-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] CRAN packaging checklist for version 12.0.0 #35216
Comments
For the first bit:
We will need a fix for #35131 merged before CRAN submission. These are just test changes and so I'm not concerned if it does not merge before the RC vote. I will tackle that tomorrow. |
As a reminder: The relatively large acero changes need to be upstreamed to auto/homebrew: #34844 |
Our reverse dependencies as of a few days ago were 💯 according to the archery job! The only mandatory fix that will need to be done/picked into the CRAN packaging branch is #35131 . |
We also want #35401 adding in |
Added #35407 too |
I ran another reverse dependency check with the release branch...all clean! The coolest thing is...we're up 10 reverse dependencies! (32 -> 42) |
@paleolimbot That's excellent; what are our new ones? |
Totally hacked together summary:
|
All the 12.0.0-relevant bits here are done, so I'm closing this now |
Describe the enhancement requested
Packaging checklist for CRAN release
For a high-level overview of the release process see the
Apache Arrow Release Management Guide.
Before the release candidate is cut:
entitled
[R] CRAN packaging checklist for version X.X.X
and copy this checklist to the issue.
nightly tests and nightly packaging builds. These checks
replicate most of the checks that CRAN runs, so we need them all to be passing
or to understand that the failures may (though won't necessarily) result in a rejection from CRAN.
urlchecker::url_check()
on the R directory at the release candidatecommit. Ignore any errors with badges as they will be removed in the CRAN release branch.
Wait for the release candidate to be cut:
Make pull requests into the autobrew and
rtools-packages repositories
used by the configure script on MacOS and Windows. These pull requests will
use the release candidate as the source.
the apache-arrow autobrew formula
to update the release version, SHA256 checksum of the release source file (which can be found in the same directory as the release source file), and any changes to dependencies and build steps that have changed in the
copy of the formula we have of that formula in the Arrow repo
the apache-arrow-static autobrew formula
to update the version, SHA, and any changes to dependencies and build steps that have changed in the
copy of the formula we have of that formula in the Arrow repo
autobrew script
to include any additions made to
r/tools/autobrew.
RTools PKGBUILD script
to reflect changes in
ci/PKGBUILD,
uncommenting the line that says "uncomment to test the rc".
Prepare and check the .tar.gz that will be released to CRAN.
git fetch upstream && git checkout release-X.X.X-rcXX && git clean -f -d
make build
. This copies Arrow C++ into tools/cpp, prunes someunnecessary components, and runs
R CMD build
to generate the source tarball.Because this will install the package, you will need to ensure that the version
of Arrow C++ available to the configure script is the same as the version
that is vendored into the R package (e.g., you may need to unset
ARROW_HOME
).devtools::check_built("arrow_X.X.X.tar.gz")
locallymanual process;
however, in the future it may be a crossbow nightly job.
Wait for the official release...
on that commit.
were needed to fix CRAN-related submission issues identified in the above
steps.
urlchecker::url_check()
on the R directoryWIP: [R] Verify CRAN release-10.0.1-rc0
. Adda comment
@github-actions crossbow submit --group r
to run all R crossbowjobs against the CRAN-specific release branch.
make build
)Create new autobrew and r-windows PRs such that they use the release
instead of the release candidate; ensure linux binary packages are available:
apache-arrow 12.0.0 autobrew/homebrew-core#124
apache-arrow 12.0.0 autobrew/homebrew-cran#77
apache-arrow 12.0.0 autobrew/scripts#15
apache-arrow 12.0.0 r-windows/rtools-packages#280
https://apache.jfrog.io/ui/repos/tree/General/arrow/r
Check binary Arrow C++ distributions specific to the R package:
and confirm (with Nic, who will automatically receive an email about the results) that the check is clean.
This step cannot be completed before Jeroen has put the binaries in the MinGW repository, i.e. here, here, and here.
and confirm that the check is clean
https://mac.r-project.org/macbuilder/results/1683287726-628f7ff77aab0dd5/
install.packages("arrow_X.X.X.tar.gz")
on Ubuntu and ensure that thehosted binaries are used
devtools::check_built("arrow_X.X.X.tar.gz")
locally one more time (for luck)Submit!
CRAN submit page
Wait for CRAN...
ci/scripts/PKGBUILD
,dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb
,r/DESCRIPTION
, andr/NEWS.md
pkgdown::build_site(examples = FALSE, lazy = TRUE, install = FALSE)
and submit a PR to theasf-site
branch of the docs site with the contents ofr/docs/news/index.html
.r/pkgdown/assets/versions.json
, and update this on the theasf-site
branch of the docs site too.packaging process.
new version
Component(s)
R
The text was updated successfully, but these errors were encountered: