Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34812: [Packaging][Python] Use self-hosted arm64 Linux runner instead of Travis CI for Linux arm64 wheels #34835

Merged
merged 8 commits into from
Apr 3, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Apr 1, 2023

Rationale for this change

Change one of the jobs that uses Travis CI to run on GitHub Actions self-hosted runner, reducing the number of Travis CI jobs.

What changes are included in this PR?

Changes to use self-hosted arm64 linux runner for Crossbow jobs building wheels.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 1, 2023
@eitsupi eitsupi changed the title [Packaging][Python] Use self-hosted arm64 runner instead of Travis CI for arm64 wheels GH-34812: [Packaging][Python] Use self-hosted arm64 runner instead of Travis CI for arm64 wheels Apr 1, 2023
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

⚠️ GitHub issue #34812 has been automatically assigned in GitHub to PR creator.

@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux*

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: b2a442c

Submitted crossbow builds: ursacomputing/crossbow @ actions-f5b646c499

Task Status
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 Github Actions
wheel-manylinux2014-cp311-amd64 Github Actions
wheel-manylinux2014-cp311-arm64 Github Actions
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 Github Actions
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 Github Actions
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi

This comment was marked as resolved.

@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux2014-cp39-arm64

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: 5c06f77

Submitted crossbow builds: ursacomputing/crossbow @ actions-300f1c78f9

Task Status
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi eitsupi force-pushed the dev-python-arm64-self-hosted-runner branch from 5c06f77 to a6d7db2 Compare April 1, 2023 08:09
@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux2014-cp39-arm64

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: a6d7db2

Submitted crossbow builds: ursacomputing/crossbow @ actions-8254ca5d1d

Task Status
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux2014-cp39-arm64

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: 90ebfb3

Submitted crossbow builds: ursacomputing/crossbow @ actions-4cee463654

Task Status
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux2014-cp39-arm64

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: cac43b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-8bf50b4a7c

Task Status
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi

This comment was marked as resolved.

@eitsupi eitsupi force-pushed the dev-python-arm64-self-hosted-runner branch from cac43b6 to 778298c Compare April 1, 2023 13:08
@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux2014-cp39-arm64

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: 778298c

Submitted crossbow builds: ursacomputing/crossbow @ actions-b19acd78ec

Task Status
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit wheel-manylinux*

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: 778298c

Submitted crossbow builds: ursacomputing/crossbow @ actions-e732e65c9b

Task Status
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 Github Actions
wheel-manylinux2014-cp311-amd64 Github Actions
wheel-manylinux2014-cp311-arm64 Github Actions
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 Github Actions
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 Github Actions
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 Github Actions

@eitsupi eitsupi marked this pull request as ready for review April 1, 2023 15:14
@eitsupi eitsupi requested a review from raulcd as a code owner April 1, 2023 15:14
@eitsupi

This comment was marked as resolved.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should some of the jinja macros be removed in this PR as they seem to be used only in the file that will be removed in this PR?

Yes, please.

dev/tasks/python-wheels/github.linux.yml Outdated Show resolved Hide resolved
@@ -49,6 +71,7 @@ jobs:
archery docker run python-wheel-manylinux-test-imports
archery docker run python-wheel-manylinux-test-unittests

{% if arch == "amd64" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable this on arm64 too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not enable these in arm64 because Travis job did not seem having this, but I will try it out.

dev/tasks/tasks.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting review Awaiting review and removed awaiting review Awaiting review labels Apr 1, 2023
Signed-off-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: SHIMA Tatsuya <[email protected]>
@github-actions github-actions bot added awaiting review Awaiting review awaiting committer review Awaiting committer review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Apr 1, 2023
@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 1, 2023

@github-actions crossbow submit -g wheel

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Revision: 65eedb8

Submitted crossbow builds: ursacomputing/crossbow @ actions-4d259964be

Task Status
wheel-clean Github Actions
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp311-arm64 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-mojave-cp310-amd64 Github Actions
wheel-macos-mojave-cp311-amd64 Github Actions
wheel-macos-mojave-cp37-amd64 Github Actions
wheel-macos-mojave-cp38-amd64 Github Actions
wheel-macos-mojave-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 Github Actions
wheel-manylinux2014-cp311-amd64 Github Actions
wheel-manylinux2014-cp311-arm64 Github Actions
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 Github Actions
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 Github Actions
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 Github Actions
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@eitsupi eitsupi changed the title GH-34812: [Packaging][Python] Use self-hosted arm64 runner instead of Travis CI for arm64 wheels GH-34812: [Packaging][Python] Use self-hosted arm64 Linux runner instead of Travis CI for Linux arm64 wheels Apr 1, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 34addbb into apache:main Apr 3, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 3, 2023
@ursabot
Copy link

ursabot commented Apr 3, 2023

Benchmark runs are scheduled for baseline = ce94fba and contender = 34addbb. 34addbb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 34addbb5 ec2-t3-xlarge-us-east-2
[Failed] 34addbb5 test-mac-arm
[Finished] 34addbb5 ursa-i9-9960x
[Failed] 34addbb5 ursa-thinkcentre-m75q
[Finished] ce94fbab ec2-t3-xlarge-us-east-2
[Failed] ce94fbab test-mac-arm
[Finished] ce94fbab ursa-i9-9960x
[Failed] ce94fbab ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@eitsupi eitsupi deleted the dev-python-arm64-self-hosted-runner branch April 3, 2023 12:19
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…r instead of Travis CI for Linux arm64 wheels (apache#34835)

### Rationale for this change

Change one of the jobs that uses Travis CI to run on GitHub Actions self-hosted runner, reducing the number of Travis CI jobs.

### What changes are included in this PR?

Changes to use self-hosted arm64 linux runner for Crossbow jobs building wheels.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#34812

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
…r instead of Travis CI for Linux arm64 wheels (apache#34835)

### Rationale for this change

Change one of the jobs that uses Travis CI to run on GitHub Actions self-hosted runner, reducing the number of Travis CI jobs.

### What changes are included in this PR?

Changes to use self-hosted arm64 linux runner for Crossbow jobs building wheels.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#34812

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Packaging][Python] Use self-hosted arm64 runner instead of Travis CI for arm64 wheels
3 participants