GH-33804: [Python] Add support for manylinux_2_28 wheel #34818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
…nt manylinux version
|
Hi I am new to Arrow and I would like to ask a dumb question here: From my understanding, the current situation (before this PR) is
Then, how come pyarrow is able to use arrow without a runtime error? Thanks! |
done |
github-actions
bot
added
awaiting change review
|
Thanks! But sorry... Please one more rebase for #35092... |
No problem! Also, sorry for always merging, its from a personal tendency to avoid rebasing and the often messy resolution processes, as well as possibly messing up the history of the github PR, but having re-read the Contributing Guidelines I'll just squash commits in future. |
|
@github-actions crossbow submit java-jars |
|
Revision: 22bb08f Submitted crossbow builds: ursacomputing/crossbow @ actions-dc1ed1ccb8
|
Looks promising. Should I rebase on main again? |
|
Not needed but cat we merge this after we release 12.0.0? |
kou
approved these changes
Apr 15, 2023
|
The 12.0.0 vote passed. |
kou
reviewed
May 3, 2023
github-actions
bot
added
awaiting changes
|
Benchmark runs are scheduled for baseline = 205ceb9 and contender = 42d42b1. 42d42b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
kou
pushed a commit
that referenced
this pull request
May 6, 2023
### Rationale for this change - #34818 pinned vcpkg to a non-release master branch commit. - This was to include unreleased changes, specifically microsoft/vcpkg#29674. ### What changes are included in this PR? This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f) ### Are these changes tested? I've successfully test that the following local wheel builds succeed: ```bash $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014 $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28 ``` ### Are there any user-facing changes? I don't believe so * Closes: #35099 Authored-by: Simon Perkins <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…#34818) Closes apache#33804 ### Rationale for this change At some point, it would be useful to support the new C++ ABI `_GLIBCXX_USE_CXX11_ABI=1` in pyarrow wheels, especially when moving to C++17: - apache#32415 I wanted to create a pyarrow wheel that supported the above ABI and adapted the existing CENTOS 7 manylinux2014 Dockerfile/wheel to produce a AlmaLinux 8 manylinux_2_28 Dockerfile/wheel. Publishing wheels with a new ABI needs [careful consideration](https://pypackaging-native.github.io/key-issues/native-dependencies/cpp_deps/) so I think this is low priority, but I thought I'd provide this manylinux_2_28 implementation in case it was useful for current/future adoption. ### What changes are included in this PR? A manylinux_2_28 Dockerfile, adopted from the existing manylinux2014 Dockerfile ### Are these changes tested? Manually tested at present ### Are there any user-facing changes? Yes, there's a major ABI change, as pyarrow will be compiled with `_GLIBCXX_USE_CXX11_ABI=1` * Closes: apache#33804 Supercedes: * apache#33805 * Closes: apache#33804 Lead-authored-by: Simon Perkins <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…pache#35430) ### Rationale for this change - apache#34818 pinned vcpkg to a non-release master branch commit. - This was to include unreleased changes, specifically microsoft/vcpkg#29674. ### What changes are included in this PR? This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f) ### Are these changes tested? I've successfully test that the following local wheel builds succeed: ```bash $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014 $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28 ``` ### Are there any user-facing changes? I don't believe so * Closes: apache#35099 Authored-by: Simon Perkins <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…#34818) Closes apache#33804 ### Rationale for this change At some point, it would be useful to support the new C++ ABI `_GLIBCXX_USE_CXX11_ABI=1` in pyarrow wheels, especially when moving to C++17: - apache#32415 I wanted to create a pyarrow wheel that supported the above ABI and adapted the existing CENTOS 7 manylinux2014 Dockerfile/wheel to produce a AlmaLinux 8 manylinux_2_28 Dockerfile/wheel. Publishing wheels with a new ABI needs [careful consideration](https://pypackaging-native.github.io/key-issues/native-dependencies/cpp_deps/) so I think this is low priority, but I thought I'd provide this manylinux_2_28 implementation in case it was useful for current/future adoption. ### What changes are included in this PR? A manylinux_2_28 Dockerfile, adopted from the existing manylinux2014 Dockerfile ### Are these changes tested? Manually tested at present ### Are there any user-facing changes? Yes, there's a major ABI change, as pyarrow will be compiled with `_GLIBCXX_USE_CXX11_ABI=1` * Closes: apache#33804 Supercedes: * apache#33805 * Closes: apache#33804 Lead-authored-by: Simon Perkins <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…pache#35430) ### Rationale for this change - apache#34818 pinned vcpkg to a non-release master branch commit. - This was to include unreleased changes, specifically microsoft/vcpkg#29674. ### What changes are included in this PR? This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f) ### Are these changes tested? I've successfully test that the following local wheel builds succeed: ```bash $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014 $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28 ``` ### Are there any user-facing changes? I don't believe so * Closes: apache#35099 Authored-by: Simon Perkins <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…#34818) Closes apache#33804 ### Rationale for this change At some point, it would be useful to support the new C++ ABI `_GLIBCXX_USE_CXX11_ABI=1` in pyarrow wheels, especially when moving to C++17: - apache#32415 I wanted to create a pyarrow wheel that supported the above ABI and adapted the existing CENTOS 7 manylinux2014 Dockerfile/wheel to produce a AlmaLinux 8 manylinux_2_28 Dockerfile/wheel. Publishing wheels with a new ABI needs [careful consideration](https://pypackaging-native.github.io/key-issues/native-dependencies/cpp_deps/) so I think this is low priority, but I thought I'd provide this manylinux_2_28 implementation in case it was useful for current/future adoption. ### What changes are included in this PR? A manylinux_2_28 Dockerfile, adopted from the existing manylinux2014 Dockerfile ### Are these changes tested? Manually tested at present ### Are there any user-facing changes? Yes, there's a major ABI change, as pyarrow will be compiled with `_GLIBCXX_USE_CXX11_ABI=1` * Closes: apache#33804 Supercedes: * apache#33805 * Closes: apache#33804 Lead-authored-by: Simon Perkins <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…pache#35430) ### Rationale for this change - apache#34818 pinned vcpkg to a non-release master branch commit. - This was to include unreleased changes, specifically microsoft/vcpkg#29674. ### What changes are included in this PR? This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f) ### Are these changes tested? I've successfully test that the following local wheel builds succeed: ```bash $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014 $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28 ``` ### Are there any user-facing changes? I don't believe so * Closes: apache#35099 Authored-by: Simon Perkins <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33804
Rationale for this change
At some point, it would be useful to support the new C++ ABI
_GLIBCXX_USE_CXX11_ABI=1in pyarrow wheels, especially when moving to C++17:I wanted to create a pyarrow wheel that supported the above ABI and adapted the existing CENTOS 7 manylinux2014 Dockerfile/wheel to produce a AlmaLinux 8 manylinux_2_28 Dockerfile/wheel.
Publishing wheels with a new ABI needs careful consideration so I think this is low priority, but I thought I'd provide this manylinux_2_28 implementation in case it was useful for current/future adoption.
What changes are included in this PR?
A manylinux_2_28 Dockerfile, adopted from the existing manylinux2014 Dockerfile
Are these changes tested?
Manually tested at present
Are there any user-facing changes?
Yes, there's a major ABI change, as pyarrow will be compiled with
_GLIBCXX_USE_CXX11_ABI=1Supercedes: