Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2172: [C++] Change field return type to const NodePtr& #13865

Merged
merged 1 commit into from
Aug 13, 2022
Merged

PARQUET-2172: [C++] Change field return type to const NodePtr& #13865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/parquet/schema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class PARQUET_EXPORT GroupNode : public Node {

bool Equals(const Node* other) const override;

NodePtr field(int i) const { return fields_[i]; }
const NodePtr& field(int i) const { return fields_[i]; }
// Get the index of a field by its name, or negative value if not found.
// If several fields share the same name, it is unspecified which one
// is returned.
Expand Down