Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-2172: [C++] Change field return type to const NodePtr& #13865

Merged
merged 1 commit into from
Aug 13, 2022
Merged

PARQUET-2172: [C++] Change field return type to const NodePtr& #13865

merged 1 commit into from
Aug 13, 2022

Conversation

emkornfield
Copy link
Contributor

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/PARQUET-2172

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@cyb70289 cyb70289 merged commit 2575ad4 into apache:master Aug 13, 2022
@ursabot
Copy link

ursabot commented Aug 13, 2022

Benchmark runs are scheduled for baseline = 39a2f3b and contender = 2575ad4. 2575ad4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️25.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.75% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2575ad41 ec2-t3-xlarge-us-east-2
[Failed] 2575ad41 test-mac-arm
[Failed] 2575ad41 ursa-i9-9960x
[Finished] 2575ad41 ursa-thinkcentre-m75q
[Finished] 39a2f3be ec2-t3-xlarge-us-east-2
[Failed] 39a2f3be test-mac-arm
[Failed] 39a2f3be ursa-i9-9960x
[Finished] 39a2f3be ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 13, 2022

['Python', 'R'] benchmarks have high level of regressions.
ec2-t3-xlarge-us-east-2
test-mac-arm
ursa-i9-9960x

ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
@emkornfield @ksuarez1423
PARQUET-2172: [C++] Change field return type to const NodePtr& (apach…
74b6a68 
…e#13865)

Authored-by: emkornfield <[email protected]>
Signed-off-by: Yibo Cai <[email protected]>
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
@emkornfield @ksuarez1423
PARQUET-2172: [C++] Change field return type to const NodePtr& (apach…
f12fb12 
…e#13865)

Authored-by: emkornfield <[email protected]>
Signed-off-by: Yibo Cai <[email protected]>
@asfimport asfimport mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: Parquet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emkornfield @ursabot @cyb70289