Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib] Add GArrowDecimal64DataType #44569

Closed
hiroyuki-sato opened this issue Oct 30, 2024 · 1 comment
Closed

[GLib] Add GArrowDecimal64DataType #44569

hiroyuki-sato opened this issue Oct 30, 2024 · 1 comment
Assignees
@hiroyuki-sato
Labels
Component: GLib Type: enhancement
Milestone
19.0.0

Comments

@hiroyuki-sato
Copy link
Contributor

Describe the enhancement requested

It's for arrow::type::Decimal64Type.

It's the same #44392

Component(s)

GLib
hiroyuki-sato added a commit to hiroyuki-sato/arrow that referenced this issue Oct 30, 2024
@hiroyuki-sato
apacheGH-44569: Add GArrowDecimal64DataType
3b5b6a4
@github-actions github-actions bot mentioned this issue Oct 30, 2024
Merged
kou pushed a commit that referenced this issue Oct 30, 2024
@hiroyuki-sato
GH-44569: [GLib] Add GArrowDecimal64DataType (#44571)
4c36f12 
### Rationale for this change

`arrow::Decimal64Type` data type has been introduced. It is also necessary to support the same data type in GLib.

### What changes are included in this PR?

This PR implements `GArrowDecimal64DataType`.

### Are these changes tested?

YES

### Are there any user-facing changes?

Before this change: `Arrow::DecimalDataType.new(8, 2)` returned `Decimal128DataType`.
After this change: `Arrow::DecimalDataType.new(8, 2)` returns `Decimal64DataType`

* GitHub Issue: #44569

Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 19.0.0 milestone Oct 30, 2024
@kou
Copy link
Member

kou commented Oct 30, 2024

Issue resolved by pull request 44571
#44571

@kou kou closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiroyuki-sato hiroyuki-sato

Labels
Component: GLib Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @hiroyuki-sato