-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLib] Add GArrowDecimal32DataType
#44392
Comments
hiroyuki-sato
added a commit
to hiroyuki-sato/arrow
that referenced
this issue
Oct 15, 2024
hiroyuki-sato
added a commit
to hiroyuki-sato/arrow
that referenced
this issue
Oct 15, 2024
hiroyuki-sato
added a commit
to hiroyuki-sato/arrow
that referenced
this issue
Oct 15, 2024
hiroyuki-sato
added a commit
to hiroyuki-sato/arrow
that referenced
this issue
Oct 30, 2024
hiroyuki-sato
added a commit
to hiroyuki-sato/arrow
that referenced
this issue
Oct 30, 2024
kou
pushed a commit
that referenced
this issue
Oct 30, 2024
### Rationale for this change `arrow::Decimal32Type` data type has been introduced. It is also necessary to support the same data type in GLib. ### What changes are included in this PR? This PR implements `GArrowDecimal32DataType`. ### Are these changes tested? YES ### Are there any user-facing changes? Before this change `garrow_decimal_data_type_new()` returns `GArrowDecimal64DataType` if the precision is less than `garrow_decimal64_data_type_max_precision()`. After this change, it returns `GArrowDecimal32DataType` if the precision is less than garrow_decimal32_data_type_max_precision(). * GitHub Issue: #44392 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Issue resolved by pull request 44580 |
@hiroyuki-sato Could you add "take" only comment here to assign you to this issue? |
take |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
It's for
arrow::type::Decimal32Type
.See also the
GArrowDecimal128DataType
implementation:arrow/c_glib/arrow-glib/basic-data-type.h
Lines 611 to 630 in 8a7224d
arrow/c_glib/arrow-glib/basic-data-type.cpp
Line 117 in 8a7224d
arrow/c_glib/arrow-glib/basic-data-type.cpp
Lines 1548 to 1599 in 8a7224d
https://github.com/apache/arrow/blob/main/c_glib/test/test-decimal128-data-type.rb
Component(s)
GLib
The text was updated successfully, but these errors were encountered: