Fix data corruption in json decoder f64-to-i64 cast #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Aug 2, 2021
|
@xianwill there is rustfmt error that needs to be addressed. |
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 168 168
Lines 47237 47243 +6
=======================================
+ Hits 38971 38977 +6
Misses 8266 8266
Continue to review full report at Codecov.
|
alamb
pushed a commit
that referenced
this pull request
Aug 5, 2021
* Add failing test for JSON writer i64 bug * Add special handling for i64/u64 to json decoder array builder * Fix linter error - linter wants .flatten on a new line
alamb
added a commit
that referenced
this pull request
Aug 6, 2021
* Add failing test for JSON writer i64 bug * Add special handling for i64/u64 to json decoder array builder * Fix linter error - linter wants .flatten on a new line Co-authored-by: Christian Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #653
Rationale for this change
Described in issue #653
What changes are included in this PR?
Add special handling for
i64andu64to the build_primitive_array method inDecoder. By avoiding the cast tof64we avoid the data corruption.Are there any user-facing changes?
No