Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RawJsonReader Integer Truncation #4049

Closed
tustvold opened this issue Apr 11, 2023 · 1 comment · Fixed by #4051 or #4074
Closed

RawJsonReader Integer Truncation #4049

tustvold opened this issue Apr 11, 2023 · 1 comment · Fixed by #4051 or #4074
Assignees
@tustvold
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

Describe the bug

The new JSON RawReader parses all numeric types as f64. Whilst this is technically correct as per the JSON standard, it differs from the behaviour of the old reader. In particular #652

To Reproduce

Expected behavior

Additional context
@tustvold tustvold added the bug label Apr 11, 2023
@tustvold tustvold self-assigned this Apr 11, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 11, 2023
@tustvold
Fix precision loss in Raw JSON decoder (apache#4049)
c688386
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 11, 2023
@tustvold
Fix precision loss in Raw JSON decoder (apache#4049)
e8381d3
@tustvold tustvold mentioned this issue Apr 11, 2023
Merged
tustvold added a commit that referenced this issue Apr 11, 2023
@tustvold
Fix precision loss in Raw JSON decoder (#4049) (#4051)
6b17775
@tustvold tustvold mentioned this issue Apr 12, 2023
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Apr 21, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
1 participant
@tustvold