Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce integration test matrix #6407

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 17, 2024

Which issue does this PR close?

Closes #6406.

Rationale for this change

This is for reducing test time.

What changes are included in this PR?

Use new ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS option introduced in apache/arrow#44099 and apache/arrow#44156.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Sep 17, 2024

Reduced:

https://github.com/apache/arrow-rs/actions/runs/10894287556/job/30230774799?pr=6407#step:12:65

Integration: Test: IPC: Rust -> Rust
Integration: Test: IPC: Rust -> C++
Integration: Test: IPC: Rust -> Java
Integration: Test: IPC: Rust -> JS
Integration: Test: IPC: Rust -> C#
Integration: Test: IPC: Rust -> Go
Integration: Test: IPC: C++ -> Rust
Integration: Test: IPC: Java -> Rust
Integration: Test: IPC: JS -> Rust
Integration: Test: IPC: C# -> Rust
Integration: Test: IPC: Go -> Rust
Integration: Test: IPC: Gold: Rust
Integration: Test: IPC: Rust -> Rust

Test time: 10m 50s -> 1m 44s

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kou! A 10x performance improvement is pretty amazing.

I double checked the CI run for this PR https://github.com/apache/arrow-rs/actions/runs/10894287556/job/30230774799?pr=6407

And it appears to be correctly running the necessary tests

Screenshot 2024-09-17 at 12 10 22 PM

❤️ thanks again

@kou
Copy link
Member Author

kou commented Sep 18, 2024

Sorry. We may rename the environment variable to ..._IMPLEMENTATIONS from ..._LANGUAGES: apache/arrow#44156

Please wait for a while...

@kou kou force-pushed the ci-integration-reduce-matrix branch from 00c2096 to 430814f Compare September 19, 2024 02:46
@kou
Copy link
Member Author

kou commented Sep 19, 2024

Updated. It still works:

https://github.com/apache/arrow-rs/actions/runs/10933530663/job/30352151242?pr=6407#step:12:66

Integration: Test: IPC: Rust -> Rust
Integration: Test: IPC: Rust -> C++
Integration: Test: IPC: Rust -> Java
Integration: Test: IPC: Rust -> JS
Integration: Test: IPC: Rust -> C#
Integration: Test: IPC: C++ -> Rust
Integration: Test: IPC: Java -> Rust
Integration: Test: IPC: JS -> Rust
Integration: Test: IPC: C# -> Rust
Integration: Test: IPC: Gold: Rust
Integration: Test: IPC: Rust -> Rust

@Dandandan Dandandan merged commit 4683c20 into apache:master Sep 20, 2024
34 checks passed
@kou kou deleted the ci-integration-reduce-matrix branch September 20, 2024 20:43
@alamb alamb added the development-process Related to development process of arrow-rs label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce integration test matrix
3 participants