Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce integration test matrix #6406

Closed
kou opened this issue Sep 17, 2024 · 0 comments · Fixed by #6407
Closed

Reduce integration test matrix #6406

kou opened this issue Sep 17, 2024 · 0 comments · Fixed by #6407
Labels
development-process Related to development process of arrow-rs

Comments

@kou
Copy link
Member

kou commented Sep 17, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

A challenge.

The current integration test uses the following test matrix:

https://github.com/apache/arrow-rs/actions/runs/10886360255/job/30206176246#step:12:62

Integration: Test: IPC: C++ -> C++
Integration: Test: IPC: C++ -> Java
Integration: Test: IPC: C++ -> JS
Integration: Test: IPC: C++ -> C#
Integration: Test: IPC: C++ -> Go
Integration: Test: IPC: C++ -> Rust
Integration: Test: IPC: Java -> C++
Integration: Test: IPC: Java -> Java
Integration: Test: IPC: Java -> JS
Integration: Test: IPC: Java -> C#
Integration: Test: IPC: Java -> Go
Integration: Test: IPC: Java -> Rust
Integration: Test: IPC: JS -> C++
Integration: Test: IPC: JS -> Java
Integration: Test: IPC: JS -> JS
Integration: Test: IPC: JS -> C#
Integration: Test: IPC: JS -> Go
Integration: Test: IPC: JS -> Rust
Integration: Test: IPC: C# -> C++
Integration: Test: IPC: C# -> Java
Integration: Test: IPC: C# -> JS
Integration: Test: IPC: C# -> C#
Integration: Test: IPC: C# -> Go
Integration: Test: IPC: C# -> Rust
Integration: Test: IPC: Go -> C++
Integration: Test: IPC: Go -> Java
Integration: Test: IPC: Go -> JS
Integration: Test: IPC: Go -> C#
Integration: Test: IPC: Go -> Go
Integration: Test: IPC: Go -> Rust
Integration: Test: IPC: Rust -> C++
Integration: Test: IPC: Rust -> Java
Integration: Test: IPC: Rust -> JS
Integration: Test: IPC: Rust -> C#
Integration: Test: IPC: Rust -> Go
Integration: Test: IPC: Rust -> Rust

But ${lang1 in apache/arrow} -> ${lang2 in apache/arrow} such as C++ -> Java are needless in apache/arrow-rs. Because they should be tested in apache/arrow's integration test.

We need only the following patterns:

Integration: Test: IPC: C++ -> Rust
Integration: Test: IPC: Java -> Rust
Integration: Test: IPC: JS -> Rust
Integration: Test: IPC: C# -> Rust
Integration: Test: IPC: Go -> Rust
Integration: Test: IPC: Rust -> C++
Integration: Test: IPC: Rust -> Java
Integration: Test: IPC: Rust -> JS
Integration: Test: IPC: Rust -> C#
Integration: Test: IPC: Rust -> Go
Integration: Test: IPC: Rust -> Rust

This will reduce test time. (The current test time: 10m 50s)

See also: apache/arrow#44062

Describe the solution you'd like

Use apache/arrow#44099 change something like apache/arrow#44062 (comment) .

Describe alternatives you've considered

None.

Additional context

None.

@kou kou added the enhancement Any new improvement worthy of a entry in the changelog label Sep 17, 2024
kou added a commit to kou/arrow-rs that referenced this issue Sep 17, 2024
kou added a commit to kou/arrow-rs that referenced this issue Sep 19, 2024
Dandandan pushed a commit that referenced this issue Sep 20, 2024
@alamb alamb added development-process Related to development process of arrow-rs and removed enhancement Any new improvement worthy of a entry in the changelog labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants