Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change concat_batches parameter to non owned reference #3480

Merged
merged 2 commits into from
Jan 6, 2023
Merged

change concat_batches parameter to non owned reference #3480

merged 2 commits into from
Jan 6, 2023

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Jan 6, 2023

Which issue does this PR close?

Closes #3456

Are there any user-facing changes?

The users will be able to call concat_batches function by passing non owned references to RecordBatch
No breaking changes. Rust magically converts &[T] to impl IntoIterator <Item=&RecordBatch> while calling concat_batches function. So existing code calling concat_batches need no change.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 6, 2023
@viirya viirya added the api-change Changes to the arrow API label Jan 6, 2023
@tustvold tustvold removed the api-change Changes to the arrow API label Jan 6, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @askoa

arrow-select/src/concat.rs Show resolved Hide resolved
@alamb
Copy link
Contributor

alamb commented Jan 6, 2023

cc @mustafasrepo

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @askoa

@tustvold tustvold merged commit d325ad2 into apache:master Jan 6, 2023
@ursabot
Copy link

ursabot commented Jan 6, 2023

Benchmark runs are scheduled for baseline = b39a20a and contender = d325ad2. d325ad2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow concat_batches to take non owned RecordBatch
5 participants