Allow concat_batches
to take non owned RecordBatch
#3456
Labels
arrow
Changes to the arrow crate
enhancement
Any new improvement worthy of a entry in the changelog
good first issue
Good for newcomers
help wanted
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We have code that has
Vec<&RecordBatch>
(notVec<RecordBatch>
) and thus we can't callconcat_batches
as that requires taking ownership. I looked at the code forconcat_batches
and it is not at all clear why it needs ownership of the RecordBatchhttps://docs.rs/arrow/30.0.0/arrow/compute/fn.concat_batches.html
Describe the solution you'd like
I would like some way to call
concat_batches
that doesn't require an bunch of owned RecordBatchesPerhaps something like this would work:
And existing callers could call concat_batches(&batches)
Describe alternatives you've considered
Additional context
in a DataFusion PR: apache/datafusion#4777 (comment)
The text was updated successfully, but these errors were encountered: