Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _dyn kernels of like, ilike, nlike, nilike kernels for dictionary support #3197

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 25, 2022

Which issue does this PR close?

Closes #1975.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 25, 2022
@viirya viirya requested a review from tustvold November 25, 2022 22:38
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to provide eq_dict or gt_dict instead this is hidden within eq_dyn, perhaps we should do the same here?

@psvri
Copy link
Contributor

psvri commented Nov 26, 2022

Thanks @viirya for implementing the rest.

@viirya
Copy link
Member Author

viirya commented Nov 26, 2022

We don't seem to provide eq_dict or gt_dict instead this is hidden within eq_dyn, perhaps we should do the same here?

I think it is because there are like_dict_scalar, nlike_dict_scalar etc for dictionary arrays. I agree that for other comparison kernels, only primitive and _dyn kernels are available. Maybe we should remove these _dict_scalar and only keep _dyn for dictionary support?

@tustvold
Copy link
Contributor

That sounds good to me

@viirya viirya changed the title Add dictionary suppport to like, ilike, nlike, nilike kernels Add _dyn kernels of like, ilike, nlike, nilike kernels for dictionary support Nov 27, 2022
@viirya viirya requested a review from tustvold November 27, 2022 03:16
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the dictionary support should be gated behind dyn_cmp_dict?

@tustvold tustvold merged commit a6daff5 into apache:master Nov 28, 2022
@ursabot
Copy link

ursabot commented Nov 28, 2022

Benchmark runs are scheduled for baseline = f985818 and contender = a6daff5. a6daff5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DictionaryArray in Like Kernels
4 participants