-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _dyn kernels of like, ilike, nlike, nilike kernels for dictionary support #3197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to provide eq_dict
or gt_dict
instead this is hidden within eq_dyn
, perhaps we should do the same here?
Thanks @viirya for implementing the rest. |
I think it is because there are |
That sounds good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the dictionary support should be gated behind dyn_cmp_dict?
Benchmark runs are scheduled for baseline = f985818 and contender = a6daff5. a6daff5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #1975.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?