Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Upgrade to pyo3 0.17 #2576

Merged
merged 1 commit into from
Aug 24, 2022
Merged

MINOR: Upgrade to pyo3 0.17 #2576

merged 1 commit into from
Aug 24, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Aug 24, 2022

Which issue does this PR close?

N/A

Rationale for this change

Rust 1.63.0 add a new lint borrow_deref_ref causing Cargo Clippy errors with pymethods that use &str as a parameter type. This issue is resolved in pyo3 0.17.

See apache/datafusion-python#38 for more information about how this is affecting an upstream project (arrow-datafusion-python).

What changes are included in this PR?

Upgrade crate version.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 24, 2022
@tustvold tustvold merged commit b34adcc into apache:master Aug 24, 2022
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = c4463ae and contender = b34adcc. b34adcc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants