Run clippy on object store tests (#2575)

apache · Aug 24, 2022 · c4463ae · c4463ae
1 parent 87290ff
commit c4463ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/object_store.yml b/.github/workflows/object_store.yml
@@ -44,7 +44,7 @@ jobs:
           rustup component add clippy
       - name: Run clippy
         run: |
-          cargo clippy -p object_store --all-features -- -D warnings
+          cargo clippy -p object_store --all-features --all-targets -- -D warnings
 
   # test the crate
   linux-test:

diff --git a/object_store/src/aws/mod.rs b/object_store/src/aws/mod.rs
@@ -622,17 +622,17 @@ mod tests {
     #[test]
     fn s3_test_config_from_env() {
         let aws_access_key_id = env::var("AWS_ACCESS_KEY_ID")
-            .unwrap_or("object_store:fake_access_key_id".into());
+            .unwrap_or_else(|_| "object_store:fake_access_key_id".into());
         let aws_secret_access_key = env::var("AWS_SECRET_ACCESS_KEY")
-            .unwrap_or("object_store:fake_secret_key".into());
+            .unwrap_or_else(|_| "object_store:fake_secret_key".into());
 
         let aws_default_region = env::var("AWS_DEFAULT_REGION")
-            .unwrap_or("object_store:fake_default_region".into());
+            .unwrap_or_else(|_| "object_store:fake_default_region".into());
 
-        let aws_endpoint =
-            env::var("AWS_ENDPOINT").unwrap_or("object_store:fake_endpoint".into());
+        let aws_endpoint = env::var("AWS_ENDPOINT")
+            .unwrap_or_else(|_| "object_store:fake_endpoint".into());
         let aws_session_token = env::var("AWS_SESSION_TOKEN")
-            .unwrap_or("object_store:fake_session_token".into());
+            .unwrap_or_else(|_| "object_store:fake_session_token".into());
 
         // required
         env::set_var("AWS_ACCESS_KEY_ID", &aws_access_key_id);