Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable value validation for Decimal256 case #2232

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Disable value validation for Decimal256 case #2232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions integration-testing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,10 @@ fn array_from_json(
}
DataType::Decimal256(precision, scale) => {
let mut b = Decimal256Builder::new(json_col.count, *precision, *scale);
// C++ interop tests involve incompatible decimal values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viirya
Hi java or c++ version, Does the decimal builder or the decimal array has the validation for the input value?
If there is no validation, how to make sure all of the element of the decimal array are valid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Decimal128 case #1766, C++ doesn't perform validation in Decimal builders. It only does validation when doing a full validating ArrayData.

unsafe {
b.disable_value_validation();
}
for (is_valid, value) in json_col
.validity
.as_ref()
Expand Down