Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1876: Explicitly declare the used features for each dependency in parquet #1895

Merged

Conversation

martin-g
Copy link
Member

@martin-g martin-g commented Jun 17, 2022

Declare that parquet module uses rand's std and std_rng features

Which issue does this PR close?

This is the third PR for #1876.
It changes just parquet/Cargo.toml.
The PR does not upgrade the dependencies!

Rationale for this change

This is a follow-up of #1881.
The build fails when building only parquet module:

$ cd parquet
$ cargo +nightly build --all-features

What changes are included in this PR?

Add "std" and "std_rng" features for rand dependency

Are there any user-facing changes?

No

…ndency in parquet

Declare that parquet module uses rand's std and std_rng features

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@paddyhoran paddyhoran added the parquet Changes to the parquet crate label Jun 17, 2022
@martin-g martin-g closed this Jun 17, 2022
@martin-g martin-g reopened this Jun 17, 2022
@tustvold tustvold merged commit 853a405 into apache:master Jun 20, 2022
@martin-g martin-g deleted the arrow-1876-disable-default-features-parquet-2 branch June 23, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants