Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly declare the features used for each dependency #1876

Closed
martin-g opened this issue Jun 14, 2022 · 1 comment · Fixed by #1898
Closed

Explicitly declare the features used for each dependency #1876

martin-g opened this issue Jun 14, 2022 · 1 comment · Fixed by #1898
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet_derive parquet_derive crate parquet Changes to the parquet crate

Comments

@martin-g
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Verifying Arrow-rs release requires 15GB of disk space.

Describe the solution you'd like

For each dependency in all Cargo.toml files explicitly disable the default features and list explicitly the features used by Arrow-rs.
This should reduce the disk space and CPU usage.

Describe alternatives you've considered

Option 1: Split the repository/project into several ones, e.g. extract parquet to its own repository.

The Arrow team prefers to keep the code in one repository for easier maintainance and development.

Additional context

N/A
@martin-g martin-g added the enhancement Any new improvement worthy of a entry in the changelog label Jun 14, 2022
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 14, 2022
@martin-g
Issue apache#1876 - Explicitly declare the used features for each dep…
f2374fa 
…endency

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 14, 2022
@martin-g
Issue apache#1876 - Explicitly declare the used features for each dep…
f89a7f9 
…endency

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 14, 2022
Merged
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 14, 2022
@martin-g
Issue apache#1876 - Enable "std" and "std_rng" features for rand in d…
0b6cd28 
…ev-dependencies

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
tustvold pushed a commit that referenced this issue Jun 15, 2022
@martin-g
Issue #1876 - Explicitly declare the used features for each dependency (
328c680 
#1877)

* Issue #1876 - Explicitly declare the used features for each dependency

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* Issue #1876 - Enable "std" and "std_rng" features for rand in dev-dependencies

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 15, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
8133746 
…ndency in arrow-flight

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 15, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
de8df66 
…ndency in arrow-flight

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 15, 2022
Merged
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 15, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
9e3a06c 
…ndency in parquet

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 15, 2022
Merged
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 15, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
96603b3 
…ndency in parquet

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
tustvold pushed a commit that referenced this issue Jun 16, 2022
@martin-g
Issue #1876: Explicitly declare the used features for each dependency…
dddedad 
… in arrow-flight (#1880)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
tustvold pushed a commit that referenced this issue Jun 16, 2022
@martin-g
Issue #1876: Explicitly declare the used features for each dependency…
f411a98 
… in parquet (#1881)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 17, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
c325744 
…ndency in parquet

Declare that parquet module uses rand's std and std_rng features

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 17, 2022
Merged
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 17, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
90e639c 
…ndency in parquet_derive

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 17, 2022
Merged
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 17, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
da8d5d6 
…ndency in parquet_derive_test

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 17, 2022
Merged
martin-g added a commit to martin-g/arrow-rs that referenced this issue Jun 17, 2022
@martin-g
Issue apache#1876: Explicitly declare the used features for each depe…
fee580b 
…ndency in integration_testing

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this issue Jun 17, 2022
Merged
tustvold pushed a commit that referenced this issue Jun 19, 2022
@martin-g
Issue #1876: Explicitly declare the used features for each dependency…
7f0855d 
… in integration_testing (#1898)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
tustvold pushed a commit that referenced this issue Jun 19, 2022
@martin-g
Issue #1876: Explicitly declare the used features for each dependency…
cc58938 
… in parquet_derive (#1896)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
tustvold pushed a commit that referenced this issue Jun 20, 2022
@martin-g
Issue #1876: Explicitly declare the used features for each dependency…
9b5bc01 
… in parquet_derive_test (#1897)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
tustvold pushed a commit that referenced this issue Jun 20, 2022
@martin-g
Issue #1876: Explicitly declare the used features for each dependency…
853a405 
… in parquet (#1895)

Declare that parquet module uses rand's std and std_rng features

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@alamb alamb added arrow Changes to the arrow crate parquet Changes to the parquet crate arrow-flight Changes to the arrow-flight crate labels Jun 23, 2022
@alamb alamb added the parquet_derive parquet_derive crate label Jun 23, 2022
@liukun4515 liukun4515 mentioned this issue Jul 5, 2022
Closed
@liukun4515
Copy link
Contributor

liukun4515 commented Jul 5, 2022 •
edited
Loading

Hi @martin-g
Please take a look this issue apache/datafusion#2835 about datafusion.

I'm not familiar with Cargo dependency management, and can't figure out the solution.

@psvri psvri mentioned this issue Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet_derive parquet_derive crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
3 participants
@martin-g @alamb @liukun4515